Remove NOTIFICATION_HISTORY_URLS_DELETED

chrome/browser/android/provider/chrome_browser_provider.h

Index: chrome/browser/android/provider/chrome_browser_provider.h
diff --git a/chrome/browser/android/provider/chrome_browser_provider.h b/chrome/browser/android/provider/chrome_browser_provider.h
index 49dc6cad36efecab1d72adf68f498fa52780765d..58582a26ae5d6f174833bbdb681db9e9b230f648 100644
--- a/chrome/browser/android/provider/chrome_browser_provider.h
+++ b/chrome/browser/android/provider/chrome_browser_provider.h
@@ -186,11 +186,16 @@ class ChromeBrowserProvider : public bookmarks::BaseBookmarkModelObserver,
   void OnHistoryChanged();
 
   // Override history::HistoryServiceObserver.
-  virtual void OnURLVisited(HistoryService* history_service,

[Miguel Garcia, 2014/12/11 10:09:12]

This method needs to remain virtual since it is overriden in the downstream (non
public) repository.

[sdefresne, 2014/12/11 10:48:06]

miguelg: It is still virtual. But C++ style guide says that methods should only
have one of "virtual", "override", "final". Since the method is "override", then
we remove "virtual" (which is redundant since you cannot override a non-virtual
method).

-                            ui::PageTransition transition,
-                            const history::URLRow& row,
-                            const history::RedirectList& redirects,
-                            base::Time visit_time) override;
+  void OnURLVisited(HistoryService* history_service,
+                    ui::PageTransition transition,
+                    const history::URLRow& row,
+                    const history::RedirectList& redirects,
+                    base::Time visit_time) override;
+  void OnURLsDeleted(HistoryService* history_service,

[Miguel Garcia, 2014/12/11 10:09:12]

and it probably makes sense to make this virtual too for the same reason (it
will be overriden downstream as well).

[sdefresne, 2014/12/11 10:48:06]

miguelg: See previous comment about "virtual", "override" and "final".

[Miguel Garcia, 2014/12/11 11:38:10]

Yeah I missed the override bit, never mind.

[nshaik, 2014/12/12 05:40:55]

Acknowledged.

+                     bool all_history,
+                     bool expired,
+                     const history::URLRows& deleted_rows,
+                     const std::set<GURL>& favicon_urls) override;
 
   // Override content::NotificationObserver.
   virtual void Observe(int type,