Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1126)

Unified Diff: chrome/browser/history/history_backend.h

Issue 773103004: Remove NOTIFICATION_HISTORY_URLS_DELETED (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Removed local variables in tests Created 6 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/history/history_backend.h
diff --git a/chrome/browser/history/history_backend.h b/chrome/browser/history/history_backend.h
index d0987e541af75e6c71a21cf38c88aa38b9cbf99b..9008e47d1f425af9ee4ffaf49894623bd150b8e2 100644
--- a/chrome/browser/history/history_backend.h
+++ b/chrome/browser/history/history_backend.h
@@ -143,6 +143,14 @@ class HistoryBackend : public base::RefCountedThreadSafe<HistoryBackend>,
// be forwarded to the HistoryServiceObservers in the correct thread.
virtual void NotifyURLsModified(const URLRows& changed_urls) = 0;
+ // Notify HistoryService that some or all of the URLs have been deleted.
+ // The event will be forwarded to the HistoryServiceObservers in the correct
+ // thread.
+ virtual void NotifyURLsDeleted(bool all_history,
+ bool expired,
+ const URLRows& deleted_rows,
+ const std::set<GURL>& favicon_urls) = 0;
+
// Broadcasts the specified notification to the notification service.
// This is implemented here because notifications must only be sent from
// the main thread. This is the only method that doesn't identify the
@@ -582,7 +590,8 @@ class HistoryBackend : public base::RefCountedThreadSafe<HistoryBackend>,
FRIEND_TEST_ALL_PREFIXES(HistoryBackendTest, UpdateVisitDuration);
FRIEND_TEST_ALL_PREFIXES(HistoryBackendTest, ExpireHistoryForTimes);
FRIEND_TEST_ALL_PREFIXES(HistoryBackendTest, DeleteFTSIndexDatabases);
-
+ FRIEND_TEST_ALL_PREFIXES(ProfileSyncServiceTypedUrlTest,
+ ProcessUserChangeRemove);
friend class ::TestingProfile;
// Computes the name of the specified database on disk.

Powered by Google App Engine
This is Rietveld 408576698