Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(662)

Side by Side Diff: chrome/browser/android/provider/chrome_browser_provider.h

Issue 773103004: Remove NOTIFICATION_HISTORY_URLS_DELETED (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Removed local variables in tests Created 6 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CHROME_BROWSER_ANDROID_PROVIDER_CHROME_BROWSER_PROVIDER_H_ 5 #ifndef CHROME_BROWSER_ANDROID_PROVIDER_CHROME_BROWSER_PROVIDER_H_
6 #define CHROME_BROWSER_ANDROID_PROVIDER_CHROME_BROWSER_PROVIDER_H_ 6 #define CHROME_BROWSER_ANDROID_PROVIDER_CHROME_BROWSER_PROVIDER_H_
7 7
8 #include "base/android/jni_weak_ref.h" 8 #include "base/android/jni_weak_ref.h"
9 #include "base/android/scoped_java_ref.h" 9 #include "base/android/scoped_java_ref.h"
10 #include "base/memory/scoped_ptr.h" 10 #include "base/memory/scoped_ptr.h"
(...skipping 168 matching lines...) Expand 10 before | Expand all | Expand 10 after
179 179
180 // Override bookmarks::BaseBookmarkModelObserver. 180 // Override bookmarks::BaseBookmarkModelObserver.
181 virtual void BookmarkModelChanged() override; 181 virtual void BookmarkModelChanged() override;
182 virtual void ExtensiveBookmarkChangesBeginning(BookmarkModel* model) override; 182 virtual void ExtensiveBookmarkChangesBeginning(BookmarkModel* model) override;
183 virtual void ExtensiveBookmarkChangesEnded(BookmarkModel* model) override; 183 virtual void ExtensiveBookmarkChangesEnded(BookmarkModel* model) override;
184 184
185 // Deals with updates to the history service. 185 // Deals with updates to the history service.
186 void OnHistoryChanged(); 186 void OnHistoryChanged();
187 187
188 // Override history::HistoryServiceObserver. 188 // Override history::HistoryServiceObserver.
189 virtual void OnURLVisited(HistoryService* history_service, 189 void OnURLVisited(HistoryService* history_service,
190 ui::PageTransition transition, 190 ui::PageTransition transition,
191 const history::URLRow& row, 191 const history::URLRow& row,
192 const history::RedirectList& redirects, 192 const history::RedirectList& redirects,
193 base::Time visit_time) override; 193 base::Time visit_time) override;
194 void OnURLsDeleted(HistoryBackend* history_backend bool all_history,
sdefresne 2014/12/08 17:41:06 This won't compile due to the missing comma. Shoul
nshaik 2014/12/08 21:29:52 aaagh, I was hoping I didnt end up doing something
195 bool expired,
196 const URLRows& deleted_rows,
197 const std::set<GURL>& favicon_urls) override;
194 198
195 // Override content::NotificationObserver. 199 // Override content::NotificationObserver.
196 virtual void Observe(int type, 200 virtual void Observe(int type,
197 const content::NotificationSource& source, 201 const content::NotificationSource& source,
198 const content::NotificationDetails& details) override; 202 const content::NotificationDetails& details) override;
199 203
200 JavaObjectWeakGlobalRef weak_java_provider_; 204 JavaObjectWeakGlobalRef weak_java_provider_;
201 205
202 // Profile must outlive this object. 206 // Profile must outlive this object.
203 // 207 //
(...skipping 12 matching lines...) Expand all
216 content::NotificationRegistrar notification_registrar_; 220 content::NotificationRegistrar notification_registrar_;
217 ScopedObserver<HistoryService, HistoryServiceObserver> 221 ScopedObserver<HistoryService, HistoryServiceObserver>
218 history_service_observer_; 222 history_service_observer_;
219 223
220 bool handling_extensive_changes_; 224 bool handling_extensive_changes_;
221 225
222 DISALLOW_COPY_AND_ASSIGN(ChromeBrowserProvider); 226 DISALLOW_COPY_AND_ASSIGN(ChromeBrowserProvider);
223 }; 227 };
224 228
225 #endif // CHROME_BROWSER_ANDROID_PROVIDER_CHROME_BROWSER_PROVIDER_H_ 229 #endif // CHROME_BROWSER_ANDROID_PROVIDER_CHROME_BROWSER_PROVIDER_H_
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698