Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(983)

Unified Diff: appengine/chromium_rietveld/codereview/views.py

Issue 773083004: Rietveld: Display the remote tracked ref in both old and new UIs (Closed) Base URL: https://chromium.googlesource.com/infra/infra@master
Patch Set: remote_branch -> target_ref Created 6 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: appengine/chromium_rietveld/codereview/views.py
diff --git a/appengine/chromium_rietveld/codereview/views.py b/appengine/chromium_rietveld/codereview/views.py
index 6796112e6ea3fbe815588f3fd18ab96778561949..a14a7914ff6195b26ab6d48e2ad1e4c8940c37ec 100644
--- a/appengine/chromium_rietveld/codereview/views.py
+++ b/appengine/chromium_rietveld/codereview/views.py
@@ -169,6 +169,7 @@ class UploadForm(forms.Form):
content_upload = forms.BooleanField(required=False)
separate_patches = forms.BooleanField(required=False)
base = forms.CharField(max_length=MAX_URL, required=False)
+ target_ref = forms.CharField(max_length=MAX_URL, required=False)
data = forms.FileField(required=False)
issue = forms.IntegerField(required=False)
reviewers = forms.CharField(max_length=MAX_REVIEWERS, required=False)
@@ -1373,6 +1374,7 @@ def _make_new(request, form):
description=form.cleaned_data['description'],
project=form.cleaned_data['project'],
base=base,
+ target_ref=form.cleaned_data.get('target_ref', None),
repo_guid=form.cleaned_data.get('repo_guid', None),
reviewers=reviewers,
required_reviewers=required_reviewers,
@@ -2162,6 +2164,7 @@ def _issue_as_dict(issue, messages, request=None):
'project': issue.project,
'issue': issue.key.id(),
'base_url': issue.base,
+ 'target_ref': issue.target_ref,
'private': issue.private,
'commit': issue.commit,
}

Powered by Google App Engine
This is Rietveld 408576698