extensions: Make sure a valid key is used to track the event-listener counts.

extensions: Make sure a valid key is used to track the event-listener counts.

The extension ID can be empty in some scenarios (e.g. <webview> in webui pages).
In such cases, use the ScriptContext's URL as the key.

BUG=434727
R=kalman@chromium.org

Committed: https://crrev.com/a0ab38510fca59d581d06e62d7973345ee5525d2
Cr-Commit-Position: refs/heads/master@{#306672}

[sadrul, 2014-12-03 00:45:37]

sadrul@chromium.org changed reviewers:
+ kalman@chromium.org

[not at google - send to devlin, 2014-12-03 17:15:46]

lgtm

https://codereview.chromium.org/773073002/diff/1/extensions/renderer/event_bi...
File extensions/renderer/event_bindings.cc (right):

https://codereview.chromium.org/773073002/diff/1/extensions/renderer/event_bi...
extensions/renderer/event_bindings.cc:176:
CHECK(crx_file::id_util::IdIsValid(extension_id) ||
Can you do this CHECK inside the GetKeyForScriptContext function? Would mean not
duplicating it below.

[sadrul, 2014-12-03 20:53:37]

https://codereview.chromium.org/773073002/diff/1/extensions/renderer/event_bi...
File extensions/renderer/event_bindings.cc (right):

https://codereview.chromium.org/773073002/diff/1/extensions/renderer/event_bi...
extensions/renderer/event_bindings.cc:176:
CHECK(crx_file::id_util::IdIsValid(extension_id) ||
On 2014/12/03 17:15:45, kalman wrote:
> Can you do this CHECK inside the GetKeyForScriptContext function? Would mean
not
> duplicating it below.

Done.

[sadrul, 2014-12-03 20:55:25]

Committed patchset #3 (id:40001) manually as
a0ab38510fca59d581d06e62d7973345ee5525d2 (presubmit successful).

[commit-bot: I haz the power, 2014-12-03 20:55:32]

Patchset 3 (id:??) landed as
https://crrev.com/a0ab38510fca59d581d06e62d7973345ee5525d2
Cr-Commit-Position: refs/heads/master@{#306672}