Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(39)

Issue 773043005: Revert of Allow RunShellCommand to work even with very large commands (Closed)

Created:
6 years ago by perezju
Modified:
6 years ago
Reviewers:
jbudorick
CC:
chromium-reviews, klundberg+watch_chromium.org, yfriedman+watch_chromium.org, jbudorick+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Revert of Allow RunShellCommand to work even with very large commands (patchset #6 id:100001 of https://codereview.chromium.org/751063002/) Reason for revert: Broke provision_devices on android perf bots Original issue's description: > Allow RunShellCommand to work even with very large commands > > Currently RunShellCommand may not work if the command passed to > adb.Shell is too large (e.g. > 1024). This CL addresses this > issue, allowing to run even very large commands, by first writing > the command as a shell script and then running it. > > BUG=436133 > > Committed: https://crrev.com/b35110e91edb38ec81c84e188b35012492bbcc28 > Cr-Commit-Position: refs/heads/master@{#307223} TBR=jbudorick@chromium.org NOTREECHECKS=true NOTRY=true BUG=436133, 439953 Committed: https://crrev.com/18c51ee4a72446a5af09b896c5d1b465882c3335 Cr-Commit-Position: refs/heads/master@{#307263}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+89 lines, -182 lines) Patch
M build/android/pylib/device/device_utils.py View 5 chunks +21 lines, -37 lines 0 comments Download
M build/android/pylib/device/device_utils_test.py View 4 chunks +32 lines, -58 lines 0 comments Download
M build/android/pylib/utils/device_temp_file.py View 1 chunk +15 lines, -23 lines 0 comments Download
M build/android/pylib/utils/device_temp_file_test.py View 1 chunk +20 lines, -62 lines 0 comments Download
M build/android/pylib/utils/md5sum.py View 1 chunk +1 line, -2 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
perezju
Created Revert of Allow RunShellCommand to work even with very large commands
6 years ago (2014-12-08 16:58:05 UTC) #1
jbudorick
lgtm
6 years ago (2014-12-08 16:58:23 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/773043005/1
6 years ago (2014-12-08 16:59:46 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
6 years ago (2014-12-08 17:00:46 UTC) #6
commit-bot: I haz the power
6 years ago (2014-12-08 17:01:31 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/18c51ee4a72446a5af09b896c5d1b465882c3335
Cr-Commit-Position: refs/heads/master@{#307263}

Powered by Google App Engine
This is Rietveld 408576698