Re-revert of "Remove SSLClientAuthHandler's RDH dependency." (https://codereview.chromium.org/59687…

Re-revert of "Remove SSLClientAuthHandler's RDH dependency." (https://codereview.chromium.org/596873002)

Reason for revert:
Causes browser crash if URL request is cancelled during client cert loading.

This is a reland of https://codereview.chromium.org/766463002/ which reverted
https://codereview.chromium.org/596873002. The revert was reverted because it
introduced a memory leak.

The source of this memory leak was a reference cycle in
chrome/browser/chromeos/net/client_cert_filter_chromeos.cc whose fix is
included in this CL. If InitIfSlotsAvailable returns true (synchronously), the
callback should not be retained. This was not a problem before as the code in
question was introduced after https://codereview.chromium.org/596873002 which
unrefcounted an object.

After this is merged into M-40, https://codereview.chromium.org/596873002
should be reworked with the crash fixed as this reference cycle is too subtle
and the object really needn't be reference-counted.

TBR=mmenke@chromium.org,benm@chromium.org,jam@chromium.org

BUG=422765, 427844, 376003
Committed: https://crrev.com/78fee7dab63602d70b5fe3f58ee114d2968187a6
Cr-Commit-Position: refs/heads/master@{#306649}

[davidben, 2014-12-02 23:51:08]

davidben@chromium.org changed reviewers:
+ mattm@chromium.org, pneubeck@chromium.org

[davidben, 2014-12-02 23:51:08]

chrome/browser/chromeos/net/client_cert_filter_chromeos.cc is the important
change. The rest is mattm's original revert cherry-picked.

mattm and pneubeck for review to start with. I'll hunt down OWNERS and/or TBR if
you two are happy.

[mattm, 2014-12-03 00:02:59]

On 2014/12/02 23:51:08, David Benjamin wrote:
> chrome/browser/chromeos/net/client_cert_filter_chromeos.cc is the important
> change. The rest is mattm's original revert cherry-picked.
> 
> mattm and pneubeck for review to start with. I'll hunt down OWNERS and/or TBR
if
> you two are happy.

Thanks for looking into this.

client_cert_filter_chromeos.cc lgtm

I'd say TBR is fine since the rest is just a revert. Alternately could split the
client_cert_filter_chromeos fix into a separate CL.

[pneubeck (no reviews), 2014-12-03 10:44:12]

chrome/browser/chromeos/net/client_cert_filter_chromeos.cc lgtm

[davidben, 2014-12-03 19:35:03]

davidben@chromium.org changed reviewers:
+ benm@chromium.org, jam@chromium.org, mmenke@chromium.org

[davidben, 2014-12-03 19:35:54]

TBR'ing jam, benm, mmenke because they were the reviewers on the original
original original CL. This is a revert of
https://codereview.chromium.org/596873002/ plus a fix to a memory leak (reviewed
by mattm and pneubeck).

[davidben, 2014-12-03 19:36:20]

The CQ bit was checked by davidben@chromium.org

[commit-bot: I haz the power, 2014-12-03 19:37:54]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/773003004/1

[commit-bot: I haz the power, 2014-12-03 19:42:18]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2014-12-03 19:43:05]

Patchset 1 (id:??) landed as
https://crrev.com/78fee7dab63602d70b5fe3f58ee114d2968187a6
Cr-Commit-Position: refs/heads/master@{#306649}