Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(205)

Unified Diff: chrome/browser/ui/libgtk2ui/select_file_dialog_impl_gtk2.cc

Issue 772983002: Fix a crash on clicking "Load unpacked extension" multiple times (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Addressed review. Created 6 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/ui/libgtk2ui/select_file_dialog_impl_gtk2.cc
diff --git a/chrome/browser/ui/libgtk2ui/select_file_dialog_impl_gtk2.cc b/chrome/browser/ui/libgtk2ui/select_file_dialog_impl_gtk2.cc
index 7a9d112961e869096df1e61ade01ec25ae9821ba..c8b03eabdc6de580437f783194b2f9e85dce6b90 100644
--- a/chrome/browser/ui/libgtk2ui/select_file_dialog_impl_gtk2.cc
+++ b/chrome/browser/ui/libgtk2ui/select_file_dialog_impl_gtk2.cc
@@ -228,6 +228,10 @@ void SelectFileDialogImplGTK::SelectFileImpl(
// and chooses 'Open Link in New Tab' when 'Ask where to save each file
// before downloading.' preference is turned on. (http://crbug.com/29213)
if (owning_window) {
+ if (IsRunning(owning_window)) {
+ LOG(ERROR) << "Select file dialog already in use!";
+ return;
Devlin 2014/12/04 20:00:14 This isn't what I was referring to. I meant an ea
+ }
owning_window->AddObserver(this);
parents_.insert(owning_window);
}
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698