Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(454)

Side by Side Diff: PRESUBMIT.py

Issue 772963003: Add android + chromeos + debug trybots to default set (Closed) Base URL: git@github.com:domokit/mojo.git@master
Patch Set: Created 6 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 # Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 """Top-level presubmit script for Chromium. 5 """Top-level presubmit script for Chromium.
6 6
7 See http://dev.chromium.org/developers/how-tos/depottools/presubmit-scripts 7 See http://dev.chromium.org/developers/how-tos/depottools/presubmit-scripts
8 for more details about the presubmit API built into gcl. 8 for more details about the presubmit API built into gcl.
9 """ 9 """
10 10
(...skipping 1533 matching lines...) Expand 10 before | Expand all | Expand 10 after
1544 return results 1544 return results
1545 1545
1546 1546
1547 def GetDefaultTryConfigs(bots=None): 1547 def GetDefaultTryConfigs(bots=None):
1548 """Returns a list of ('bot', set(['tests']), optionally filtered by [bots]. 1548 """Returns a list of ('bot', set(['tests']), optionally filtered by [bots].
1549 1549
1550 If 'bots' is specified, will only return configurations for bots in that list. 1550 If 'bots' is specified, will only return configurations for bots in that list.
1551 """ 1551 """
1552 1552
1553 builders_and_tests = { 1553 builders_and_tests = {
1554 # TODO(maruel): Figure out a way to run 'sizes' where people can
1555 # effectively update the perf expectation correctly. This requires a
1556 # clobber=True build running 'sizes'. 'sizes' is not accurate with
1557 # incremental build. Reference:
1558 # http://chromium.org/developers/tree-sheriffs/perf-sheriffs.
1559 # TODO(maruel): An option would be to run 'sizes' but not count a failure
1560 # of this step as a try job failure.
1561 'Mojo Linux Try': ['defaulttests'], 1554 'Mojo Linux Try': ['defaulttests'],
1555 'Mojo Linux (dbg) Try': ['defaulttests'],
1556 'Mojo Android Builder Try': ['defaulttests'],
1557 'Mojo Android Builder (dbg) Try': ['defaulttests'],
1558 'Mojo ChromeOS Builder Try': ['defaulttests'],
1559 'Mojo ChromeOS Builder (dbg) Try': ['defaulttests'],
1562 } 1560 }
1563 1561
1564 if bots: 1562 if bots:
1565 filtered_builders_and_tests = dict((bot, set(builders_and_tests[bot])) 1563 filtered_builders_and_tests = dict((bot, set(builders_and_tests[bot]))
1566 for bot in bots) 1564 for bot in bots)
1567 else: 1565 else:
1568 filtered_builders_and_tests = dict( 1566 filtered_builders_and_tests = dict(
1569 (bot, set(tests)) 1567 (bot, set(tests))
1570 for bot, tests in builders_and_tests.iteritems()) 1568 for bot, tests in builders_and_tests.iteritems())
1571 1569
(...skipping 16 matching lines...) Expand all
1588 1586
1589 def GetPreferredTryMasters(project, change): 1587 def GetPreferredTryMasters(project, change):
1590 import re 1588 import re
1591 files = change.LocalPaths() 1589 files = change.LocalPaths()
1592 1590
1593 if not files or all(re.search(r'[\\\/]OWNERS$', f) for f in files): 1591 if not files or all(re.search(r'[\\\/]OWNERS$', f) for f in files):
1594 return {} 1592 return {}
1595 1593
1596 builders = [ 1594 builders = [
1597 'Mojo Linux Try', 1595 'Mojo Linux Try',
1596 'Mojo Linux (dbg) Try',
1597 'Mojo Android Builder Try',
1598 'Mojo Android Builder (dbg) Try',
1599 'Mojo ChromeOS Builder Try',
1600 'Mojo ChromeOS Builder (dbg) Try',
1598 ] 1601 ]
1599 1602
1600 return GetDefaultTryConfigs(builders) 1603 return GetDefaultTryConfigs(builders)
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698