Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(160)

Side by Side Diff: ash/shelf/shelf_view.h

Issue 772963002: Make the second click on the app shelf icon close the window-list bubble. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Compare the time stamp when the mouse is pressed down. Created 6 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | ash/shelf/shelf_view.cc » ('j') | ash/shelf/shelf_view.cc » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef ASH_SHELF_SHELF_VIEW_H_ 5 #ifndef ASH_SHELF_SHELF_VIEW_H_
6 #define ASH_SHELF_SHELF_VIEW_H_ 6 #define ASH_SHELF_SHELF_VIEW_H_
7 7
8 #include <utility> 8 #include <utility>
9 #include <vector> 9 #include <vector>
10 10
(...skipping 417 matching lines...) Expand 10 before | Expand all | Expand 10 after
428 428
429 // True when this ShelfView is used for Overflow Bubble. 429 // True when this ShelfView is used for Overflow Bubble.
430 bool overflow_mode_; 430 bool overflow_mode_;
431 431
432 // Holds a pointer to main ShelfView when a ShelfView is in overflow mode. 432 // Holds a pointer to main ShelfView when a ShelfView is in overflow mode.
433 ShelfView* main_shelf_; 433 ShelfView* main_shelf_;
434 434
435 // True when ripped item from overflow bubble is entered into Shelf. 435 // True when ripped item from overflow bubble is entered into Shelf.
436 bool dragged_off_from_overflow_to_shelf_; 436 bool dragged_off_from_overflow_to_shelf_;
437 437
438 // False if the event is a reposted event from a event which has just closed
439 // the same menu.
440 bool is_usable_event_;
Mr4D (OOO till 08-26) 2014/12/05 15:21:48 The name is rather misleading. How about "is_repos
xdai1 2014/12/05 19:01:46 Done.
441
442 // Record the index for the last pressed |ShelfItem|.
443 int last_view_index_;
Mr4D (OOO till 08-26) 2014/12/05 15:21:48 You might not need this. Please see comment below.
xdai1 2014/12/05 19:01:47 We may still need this. Please see comment in shel
444
438 DISALLOW_COPY_AND_ASSIGN(ShelfView); 445 DISALLOW_COPY_AND_ASSIGN(ShelfView);
439 }; 446 };
440 447
441 } // namespace ash 448 } // namespace ash
442 449
443 #endif // ASH_SHELF_SHELF_VIEW_H_ 450 #endif // ASH_SHELF_SHELF_VIEW_H_
OLDNEW
« no previous file with comments | « no previous file | ash/shelf/shelf_view.cc » ('j') | ash/shelf/shelf_view.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698