Make the second click on the app shelf icon close the window-list bubble.

ash/shelf/shelf_view.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "ash/shelf/shelf_view.h"
 
 #include <algorithm>
 
 #include "ash/ash_constants.h"
 #include "ash/ash_switches.h"
@@ skipping 371 matching lines @@
       closing_event_time_(base::TimeDelta()),
       got_deleted_(NULL),
       drag_and_drop_item_pinned_(false),
       drag_and_drop_shelf_id_(0),
       dragged_off_shelf_(false),
       snap_back_from_rip_off_view_(NULL),
       item_manager_(Shell::GetInstance()->shelf_item_delegate_manager()),
       layout_manager_(manager),
       overflow_mode_(false),
       main_shelf_(NULL),
-      dragged_off_from_overflow_to_shelf_(false) {
+      dragged_off_from_overflow_to_shelf_(false),
+      pressed_on_same_position_(false) {
   DCHECK(model_);
   bounds_animator_.reset(new views::BoundsAnimator(this));
   bounds_animator_->AddObserver(this);
   set_context_menu_controller(this);
   focus_search_.reset(new ShelfFocusSearch(view_model_.get()));
   tooltip_.reset(new ShelfTooltipManager(manager, this));
 }
 
 ShelfView::~ShelfView() {
   bounds_animator_->RemoveObserver(this);
@@ skipping 1149 matching lines @@
     AnimateToIdealBounds();
 }
 
 void ShelfView::ShelfStatusChanged() {
   // Nothing to do here.
 }
 
 void ShelfView::PointerPressedOnButton(views::View* view,
                                        Pointer pointer,
                                        const ui::LocatedEvent& event) {
+  // Compare the current position with the previous one.
+  // If |pressed_on_same_position_| equals true, which means the previous
+  // pointer press was ignored, reset it to false to make sure the current
+  // press event won't be ignored in ShelfView::ButtonPressed(...). Otherwise
+  // if the current press position is the same with the previous one, ignore
+  // the current press event.

[Mr4D (OOO till 08-26), 2014/12/02 21:40:12]

You do not want to do this because of various reasons:

- A double click is usually always wiggling in its location. 
- A double click only counts as such if various timings are met.

I think what you want is to check (event.type() & EF_IS_DOUBLE_CLICK) to see if
the user double clicked at roughly the same spot.

However - looking at the bug in particular, I guess you do not want to do
anything here, but instead in line 1696:

You want to check in line 1734 if the menu is currently open and if it is, you
want to close it, mark the event as handled and return instead.

+  gfx::Point current_position = gfx::Point(event.x(), event.y());
+  if (pressed_on_same_position_)
+    pressed_on_same_position_ = false;
+  else if (pointer_pressed_position_ == current_position)
+    pressed_on_same_position_ = true;
+  pointer_pressed_position_ = current_position;
+
   if (drag_view_)
     return;
 
   int index = view_model_->GetIndexOfView(view);
   if (index == -1)
     return;
 
   ShelfItemDelegate* item_delegate = item_manager_->GetShelfItemDelegate(
       model_->items()[index].id);
   if (view_model_->view_size() <= 1 || !item_delegate->IsDraggable())
@@ skipping 89 matching lines @@
   int view_index = view_model_->GetIndexOfView(sender);
   // May be -1 while in the process of animating closed.
   if (view_index == -1)
     return;
 
   // If the previous menu was closed by the same event as this one, we ignore
   // the call.
   if (!IsUsableEvent(event))
     return;
 
+  // If the current press position is the same with the previous one, we ignore
+  // this one.
+  if (pressed_on_same_position_)
+    return;
+
   // Don't activate the item twice on double-click. Otherwise the window starts
   // animating open due to the first click, then immediately minimizes due to
   // the second click. The user most likely intended to open or minimize the
   // item once, not do both.
   if (event.flags() & ui::EF_IS_DOUBLE_CLICK)
     return;
 
   {
     ScopedTargetRootWindow scoped_target(
         sender->GetWidget()->GetNativeView()->GetRootWindow());
@@ skipping 244 matching lines @@
       distance = bounds.x() - coordinate.x();
       break;
     case SHELF_ALIGNMENT_TOP:
       distance = coordinate.y() - bounds.bottom();
       break;
   }
   return distance > 0 ? distance : 0;
 }
 
 }  // namespace ash