Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(157)

Issue 772953002: check matrix does not have rotation or perspective transformation (Closed)

Created:
6 years ago by derekf
Modified:
6 years ago
Reviewers:
bsalomon
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Project:
skia
Visibility:
Public.

Description

check matrix does not have rotation or perspective transformation When checking whether we need apply AA to a rect for non-msaa target, simply checking that the mapped rect is integer is not enough. We need to check whether the transformation matrix has transformations other than simple translation. Original-Author: Henry Song <henrysong@samsung.com>; Committed: https://skia.googlesource.com/skia/+/e638d1c29b2895a4dcf41b5bc8868278192bf819

Patch Set 1 #

Total comments: 1

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -0 lines) Patch
M src/gpu/GrContext.cpp View 1 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
derekf
This cropped up recently when commit 6dc413673 made bitmaps use drawrect to get anti-aliased edges. ...
6 years ago (2014-12-02 20:44:30 UTC) #2
bsalomon
https://codereview.chromium.org/772953002/diff/1/src/gpu/GrContext.cpp File src/gpu/GrContext.cpp (right): https://codereview.chromium.org/772953002/diff/1/src/gpu/GrContext.cpp#newcode653 src/gpu/GrContext.cpp:653: if (!combinedMatrix.rectStaysRect()) style nit: we always use { }. ...
6 years ago (2014-12-02 21:36:57 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/772953002/20001
6 years ago (2014-12-02 21:40:52 UTC) #5
commit-bot: I haz the power
6 years ago (2014-12-02 21:51:33 UTC) #6
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://skia.googlesource.com/skia/+/e638d1c29b2895a4dcf41b5bc8868278192bf819

Powered by Google App Engine
This is Rietveld 408576698