Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(487)

Issue 772913003: Paint invalidation: Need to check offset cacheability for invalidation containers. (Closed)

Created:
6 years ago by mstensho (USE GERRIT)
Modified:
6 years ago
Reviewers:
chrishtr
CC:
blink-reviews, blink-reviews-rendering, Dominik Röttsches, eae+blinkwatch, jchaffraix+rendering, leviw+renderwatch, pdr+renderingwatchlist_chromium.org, zoltan1
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Project:
blink
Visibility:
Public.

Description

Paint invalidation: Need to check offset cacheability for invalidation containers. A check for supportsPaintInvalidationStateCachedOffsets() was missing for renderers establishing a paint invalidation container, which incorrectly made us assume that offsets were always cacheable for paint invalidation containers. BUG=438901 R=chrishtr@chromium.org Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=186938

Patch Set 1 #

Patch Set 2 : repaint test n00b fixes. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+48 lines, -9 lines) Patch
A LayoutTests/fast/repaint/multicol-as-paint-container.html View 1 1 chunk +20 lines, -0 lines 0 comments Download
A + LayoutTests/fast/repaint/multicol-as-paint-container-expected.txt View 1 1 chunk +4 lines, -3 lines 0 comments Download
A LayoutTests/fast/repaint/vertical-rl-as-paint-container.html View 1 1 chunk +17 lines, -0 lines 0 comments Download
A + LayoutTests/fast/repaint/vertical-rl-as-paint-container-expected.txt View 1 1 chunk +4 lines, -3 lines 0 comments Download
M Source/core/rendering/PaintInvalidationState.cpp View 1 chunk +3 lines, -3 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
mstensho (USE GERRIT)
6 years ago (2014-12-10 21:17:41 UTC) #1
chrishtr
lgtm
6 years ago (2014-12-10 22:21:18 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/772913003/1
6 years ago (2014-12-10 22:21:55 UTC) #4
commit-bot: I haz the power
Try jobs failed on following builders: mac_blink_rel on tryserver.blink (http://build.chromium.org/p/tryserver.blink/builders/mac_blink_rel/builds/34733)
6 years ago (2014-12-11 01:24:42 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/772913003/20001
6 years ago (2014-12-11 08:49:13 UTC) #8
commit-bot: I haz the power
6 years ago (2014-12-11 10:53:17 UTC) #9
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=186938

Powered by Google App Engine
This is Rietveld 408576698