DevTools: refactor outline dialogs to run callback on item selection

Source/devtools/front_end/FilteredItemSelectionDialog.js

 /*
  * Copyright (C) 2012 Google Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions are
  * met:
  *
  *     * Redistributions of source code must retain the above copyright
  * notice, this list of conditions and the following disclaimer.
  *     * Redistributions in binary form must reproduce the above
@@ skipping 465 matching lines @@
     dispose: function()
     {
     }
 }
 
 /**
  * @constructor
  * @extends {WebInspector.SelectionDialogContentProvider}
  * @param {WebInspector.View} view
  * @param {WebInspector.ContentProvider} contentProvider
+ * @param {function(number, number)} selectItemCallback
  */
-WebInspector.JavaScriptOutlineDialog = function(view, contentProvider)
+WebInspector.JavaScriptOutlineDialog = function(view, contentProvider, selectItemCallback)
 {
     WebInspector.SelectionDialogContentProvider.call(this);
 
     this._functionItems = [];
     this._view = view;
+    this._selectItemCallback = selectItemCallback;
     contentProvider.requestContent(this._contentAvailable.bind(this));
 }
 
 /**
  * @param {WebInspector.View} view
  * @param {WebInspector.ContentProvider} contentProvider
+ * @param {function(number, number)} selectItemCallback
  */
-WebInspector.JavaScriptOutlineDialog.show = function(view, contentProvider)
+WebInspector.JavaScriptOutlineDialog.show = function(view, contentProvider, selectItemCallback)
 {
     if (WebInspector.Dialog.currentInstance())
         return null;
-    var filteredItemSelectionDialog = new WebInspector.FilteredItemSelectionDialog(new WebInspector.JavaScriptOutlineDialog(view, contentProvider));
+    var filteredItemSelectionDialog = new WebInspector.FilteredItemSelectionDialog(new WebInspector.JavaScriptOutlineDialog(view, contentProvider, selectItemCallback));
     WebInspector.Dialog.show(view.element, filteredItemSelectionDialog);
 }
 
 WebInspector.JavaScriptOutlineDialog.prototype = {
     /**
      * @param {?string} content
      */
     _contentAvailable: function(content)
     {
         this._outlineWorker = new Worker("ScriptFormatterWorker.js");
@@ skipping 58 matching lines @@
     },
 
     /**
      * @param {number} itemIndex
      * @param {string} promptValue
      */
     selectItem: function(itemIndex, promptValue)
     {
         var lineNumber = this._functionItems[itemIndex].line;
         if (!isNaN(lineNumber) && lineNumber >= 0)
-            this._view.highlightPosition(lineNumber, this._functionItems[itemIndex].column);
-        this._view.focus();
+            this._selectItemCallback(lineNumber, this._functionItems[itemIndex].column);
     },
 
     dispose: function()
     {
         if (this._outlineWorker) {
             this._outlineWorker.terminate();
             delete this._outlineWorker;
         }
     },
 
@@ skipping 262 matching lines @@
 WebInspector.SelectUISourceCodeForProjectTypeDialog.show = function(name, type, callback, relativeToElement)
 {
     if (WebInspector.Dialog.currentInstance())
         return;
 
     var filteredItemSelectionDialog = new WebInspector.FilteredItemSelectionDialog(new WebInspector.SelectUISourceCodeForProjectTypeDialog(type, callback));
     filteredItemSelectionDialog.setQuery(name);
     filteredItemSelectionDialog.renderAsTwoRows();
     WebInspector.Dialog.show(relativeToElement, filteredItemSelectionDialog);
 }