Issue 77283005: DevTools: refactor outline dialogs to run callback on item selection

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 77283005: DevTools: refactor outline dialogs to run callback on item selection (Closed)

Created:
7 years, 1 month ago by lushnikov

Modified:
7 years ago

Reviewers:
vsevik

CC:
blink-reviews, caseq+blink_chromium.org, loislo+blink_chromium.org, eustas+blink_chromium.org, alph+blink_chromium.org, yurys+blink_chromium.org, lushnikov+blink_chromium.org, vsevik+blink_chromium.org, pfeldman+blink_chromium.org, paulirish+reviews_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, aandrey+blink_chromium.org

Base URL:
svn://svn.chromium.org/blink/trunk

Visibility:
Public.

More Reviews

Description

DevTools: refactor outline dialogs to run callback on item selection This patch refactors outline dialogs to run specified callback on item selection. This is a prework for the "jump to previous editing location" feature. BUG=281507 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=162570

Patch Set 1 #

Created: 7 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+32 lines, -13 lines)			Patch
M	Source/devtools/front_end/FilteredItemSelectionDialog.js	View	2 chunks	+7 lines, -5 lines	0 comments	Download
M	Source/devtools/front_end/SourcesPanel.js	View	2 chunks	+18 lines, -2 lines	0 comments	Download
M	Source/devtools/front_end/StyleSheetOutlineDialog.js	View	3 chunks	+7 lines, -6 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/lushnikov@chromium.org/77283005/1

7 years ago (2013-11-23 02:06:38 UTC) #3

Message was sent while issue was closed.

Change committed as 162570

Expand Messages | Collapse Messages