Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(468)

Issue 772823002: Make test-parsing faster: don't run parsing tests with all experimental flag combinations. (Closed)

Created:
6 years ago by marja
Modified:
6 years ago
Reviewers:
rossberg
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Project:
v8
Visibility:
Public.

Description

Make test-parsing faster: don't run parsing tests with all experimental flag combinations. Instead, make it possible for indifidual tests to pass "always true flags" which are not part of the varying flag set. The downside is that if an experimental flag changes parsing of some of the unrelated code snippets, it's noticed later (only after the flag is turned on by default). But this is a reasonable trade off for faster tests. Additional fix: Some tests (ErrorsFutureStrictReservedWords) were using always_flags incorrectly (running two different tests with different always_flags basically iterates over every flag combination anyway - most of them twice). BUG=v8:3707 LOG=N

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -23 lines) Patch
M test/cctest/test-parsing.cc View 4 chunks +6 lines, -23 lines 0 comments Download

Messages

Total messages: 10 (4 generated)
marja
rossberg, ptal.
6 years ago (2014-12-02 13:46:52 UTC) #2
rossberg
lgtm
6 years ago (2014-12-02 13:52:19 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/772823002/1
6 years ago (2014-12-02 13:55:24 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: v8_linux_arm64_rel on tryserver.v8 (http://build.chromium.org/p/tryserver.v8/builders/v8_linux_arm64_rel/builds/1468)
6 years ago (2014-12-02 14:14:18 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/772823002/1
6 years ago (2014-12-03 08:16:22 UTC) #9
commit-bot: I haz the power
6 years ago (2014-12-03 08:23:44 UTC) #10
Message was sent while issue was closed.
Committed patchset #1 (id:1)

Powered by Google App Engine
This is Rietveld 408576698