Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(92)

Unified Diff: sky/engine/core/dom/Node.h

Issue 772743004: Remove more Node API. (Closed) Base URL: git@github.com:domokit/mojo.git@master
Patch Set: Created 6 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « sky/engine/core/dom/Element.cpp ('k') | sky/engine/core/dom/Node.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: sky/engine/core/dom/Node.h
diff --git a/sky/engine/core/dom/Node.h b/sky/engine/core/dom/Node.h
index 4b854f23e736ce90392e926c0a45109043dacc26..bf6de3a8ea4386bf7533c956ce436c5c90ed85c2 100644
--- a/sky/engine/core/dom/Node.h
+++ b/sky/engine/core/dom/Node.h
@@ -164,9 +164,6 @@ public:
virtual PassRefPtr<Node> cloneNode(bool deep = false) = 0;
virtual const AtomicString& localName() const;
- bool isSameNode(Node* other) const { return this == other; }
- bool isEqualNode(Node*) const;
-
String textContent(bool convertBRsToNewlines = false) const;
void setTextContent(const String&);
@@ -191,8 +188,6 @@ public:
}
void setCustomElementState(CustomElementState newState);
- virtual bool isCharacterDataNode() const { return false; }
-
// StyledElements allow inline style (style="border: 1px"), presentational attributes (ex. color),
// class names (ex. class="foo bar") and other non-basic styling features. They and also control
// if this element can participate in style sharing.
@@ -300,14 +295,6 @@ public:
virtual short tabIndex() const;
- virtual Node* focusDelegate();
- // This is called only when the node is focused.
- virtual bool shouldHaveFocusAppearance() const;
-
- // Whether the node is inert. This can't be in Element because text nodes
- // must be recognized as inert to prevent text selection.
- bool isInert() const;
-
enum UserSelectAllTreatment {
UserSelectAllDoesNotAffectEditability,
UserSelectAllIsAlwaysNonEditable
@@ -456,9 +443,10 @@ public:
void showTreeAndMark(const Node* markedNode1, const char* markedLabel1, const Node* markedNode2 = 0, const char* markedLabel2 = 0) const;
#endif
- virtual bool willRespondToMouseMoveEvents();
+ bool willRespondToMouseMoveEvents();
+ bool willRespondToTouchEvents();
+
virtual bool willRespondToMouseClickEvents();
- virtual bool willRespondToTouchEvents();
enum ShadowTreesTreatment {
TreatShadowTreesAsDisconnected,
@@ -473,15 +461,8 @@ public:
virtual ExecutionContext* executionContext() const override final;
virtual bool addEventListener(const AtomicString& eventType, PassRefPtr<EventListener>, bool useCapture = false) override;
- virtual bool removeEventListener(const AtomicString& eventType, PassRefPtr<EventListener>, bool useCapture = false) override;
- virtual void removeAllEventListeners() override;
void removeAllEventListenersRecursively();
- // Handlers to do/undo actions on the target node before an event is dispatched to it and after the event
- // has been dispatched. The data pointer is handed back by the preDispatch and passed to postDispatch.
- virtual void* preDispatchEventHandler(Event*) { return 0; }
- virtual void postDispatchEventHandler(Event*, void* /*dataFromPreDispatch*/) { }
-
using EventTarget::dispatchEvent;
virtual bool dispatchEvent(PassRefPtr<Event>) override;
@@ -652,10 +633,10 @@ private:
HashSet<RawPtr<MutationObserverRegistration> >* transientMutationObserverRegistry();
uint32_t m_nodeFlags;
- RawPtr<ContainerNode> m_parentOrShadowHostNode;
- RawPtr<TreeScope> m_treeScope;
- RawPtr<Node> m_previous;
- RawPtr<Node> m_next;
+ ContainerNode* m_parentOrShadowHostNode;
+ TreeScope* m_treeScope;
+ Node* m_previous;
+ Node* m_next;
// When a node has rare data we move the renderer into the rare data.
union DataUnion {
DataUnion() : m_renderer(0) { }
« no previous file with comments | « sky/engine/core/dom/Element.cpp ('k') | sky/engine/core/dom/Node.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698