Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(408)

Unified Diff: sky/engine/core/dom/CharacterData.h

Issue 772743004: Remove more Node API. (Closed) Base URL: git@github.com:domokit/mojo.git@master
Patch Set: Created 6 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | sky/engine/core/dom/Document.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: sky/engine/core/dom/CharacterData.h
diff --git a/sky/engine/core/dom/CharacterData.h b/sky/engine/core/dom/CharacterData.h
index aef4940ee545d361bad8bbe71855654b123be291..277a47e73f9cac5615ea4286b78a6284aef7a4cf 100644
--- a/sky/engine/core/dom/CharacterData.h
+++ b/sky/engine/core/dom/CharacterData.h
@@ -69,7 +69,6 @@ protected:
String m_data;
private:
- virtual bool isCharacterDataNode() const override final { return true; }
virtual int maxCharacterOffset() const override final;
virtual bool offsetInCharacters() const override final;
void setDataAndUpdate(const String&, unsigned offsetOfReplacedData, unsigned oldLength, unsigned newLength, RecalcStyleBehavior = DoNotRecalcStyle);
@@ -78,7 +77,8 @@ private:
bool isElementNode() const = delete; // This will catch anyone doing an unnecessary check.
};
-DEFINE_NODE_TYPE_CASTS(CharacterData, isCharacterDataNode());
+// TODO(esprehn): In sky all CharacterData nodes are Text, merge the classes.
+DEFINE_NODE_TYPE_CASTS(CharacterData, isTextNode());
} // namespace blink
« no previous file with comments | « no previous file | sky/engine/core/dom/Document.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698