Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(652)

Unified Diff: sky/engine/core/animation/Animation.cpp

Issue 772673002: Fix Animations, Remove Compostior Animations. (Closed) Base URL: https://github.com/domokit/mojo.git@master
Patch Set: cleanup Created 6 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: sky/engine/core/animation/Animation.cpp
diff --git a/sky/engine/core/animation/Animation.cpp b/sky/engine/core/animation/Animation.cpp
index d7d3d15bb5adf0ae02baaf7bde903eee6d22c978..1088adcca9a1f82a446214fdf60f9b19131fbb1e 100644
--- a/sky/engine/core/animation/Animation.cpp
+++ b/sky/engine/core/animation/Animation.cpp
@@ -37,7 +37,6 @@
#include "sky/engine/core/animation/AnimationHelpers.h"
#include "sky/engine/core/animation/AnimationPlayer.h"
#include "sky/engine/core/animation/AnimationTimeline.h"
-#include "sky/engine/core/animation/CompositorAnimations.h"
#include "sky/engine/core/animation/Interpolation.h"
#include "sky/engine/core/animation/KeyframeEffectModel.h"
#include "sky/engine/core/dom/Element.h"
@@ -168,7 +167,7 @@ void Animation::clearEffects()
m_sampledEffect->clear();
m_sampledEffect = nullptr;
- cancelAnimationOnCompositor();
+ // cancelAnimationOnCompositor();
m_target->setNeedsAnimationStyleRecalc();
invalidate();
}
@@ -195,16 +194,6 @@ double Animation::calculateTimeToEffectChange(bool forwards, double localTime, d
? start - localTime
: std::numeric_limits<double>::infinity();
case PhaseActive:
- if (forwards && hasActiveAnimationsOnCompositor()) {
- ASSERT(specifiedTiming().playbackRate == 1);
- // Need service to apply fill / fire events.
- const double timeToEnd = end - localTime;
- if (hasEvents()) {
- return std::min(timeToEnd, timeToNextIteration);
- } else {
- return timeToEnd;
- }
- }
return 0;
case PhaseAfter:
ASSERT(localTime >= end);
@@ -239,60 +228,4 @@ void Animation::notifyElementDestroyed()
sampledEffect->clear();
}
-bool Animation::isCandidateForAnimationOnCompositor() const
-{
- if (!effect() || !m_target)
- return false;
- return CompositorAnimations::instance()->isCandidateForAnimationOnCompositor(specifiedTiming(), *effect());
-}
-
-bool Animation::maybeStartAnimationOnCompositor(double startTime, double currentTime)
-{
- ASSERT(!hasActiveAnimationsOnCompositor());
- if (!isCandidateForAnimationOnCompositor())
- return false;
- if (!CompositorAnimations::instance()->canStartAnimationOnCompositor(*m_target))
- return false;
- if (!CompositorAnimations::instance()->startAnimationOnCompositor(*m_target, startTime, currentTime, specifiedTiming(), *effect(), m_compositorAnimationIds))
- return false;
- ASSERT(!m_compositorAnimationIds.isEmpty());
- return true;
-}
-
-bool Animation::hasActiveAnimationsOnCompositor() const
-{
- return !m_compositorAnimationIds.isEmpty();
-}
-
-bool Animation::hasActiveAnimationsOnCompositor(CSSPropertyID property) const
-{
- return hasActiveAnimationsOnCompositor() && affects(property);
-}
-
-bool Animation::affects(CSSPropertyID property) const
-{
- return m_effect && m_effect->affects(property);
-}
-
-void Animation::cancelAnimationOnCompositor()
-{
- if (!hasActiveAnimationsOnCompositor())
- return;
- if (!m_target || !m_target->renderer())
- return;
- for (size_t i = 0; i < m_compositorAnimationIds.size(); ++i)
- CompositorAnimations::instance()->cancelAnimationOnCompositor(*m_target, m_compositorAnimationIds[i]);
- m_compositorAnimationIds.clear();
- player()->setCompositorPending(true);
-}
-
-void Animation::pauseAnimationForTestingOnCompositor(double pauseTime)
-{
- ASSERT(hasActiveAnimationsOnCompositor());
- if (!m_target || !m_target->renderer())
- return;
- for (size_t i = 0; i < m_compositorAnimationIds.size(); ++i)
- CompositorAnimations::instance()->pauseAnimationForTestingOnCompositor(*m_target, m_compositorAnimationIds[i], pauseTime);
-}
-
} // namespace blink

Powered by Google App Engine
This is Rietveld 408576698