Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2)

Issue 772663002: gn format: Make parenthesizing better (Closed)

Created:
6 years ago by scottmg
Modified:
6 years ago
Reviewers:
brettw
CC:
chromium-reviews, tfarina
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

gn format: Make parenthesizing better - Fixes one bug (the precedence of suffix vs. unary did not match parsing) - Adds "redundant" parentheses in the case of && and || because they're otherwise too confusing to read. R=brettw@chromium.org BUG=348474 Committed: https://crrev.com/3e2c7b0b7caaa0cc28eff1d3726b1c34f6c150fe Cr-Commit-Position: refs/heads/master@{#306282}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+103 lines, -20 lines) Patch
M tools/gn/command_format.cc View 12 chunks +48 lines, -19 lines 0 comments Download
M tools/gn/command_format_unittest.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M tools/gn/format_test_data/016.golden View 1 chunk +1 line, -1 line 0 comments Download
A tools/gn/format_test_data/057.gn View 1 chunk +24 lines, -0 lines 0 comments Download
A tools/gn/format_test_data/057.golden View 1 chunk +24 lines, -0 lines 0 comments Download
A tools/gn/format_test_data/058.gn View 1 chunk +2 lines, -0 lines 0 comments Download
A tools/gn/format_test_data/058.golden View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (1 generated)
scottmg
6 years ago (2014-12-01 21:00:14 UTC) #1
brettw
lgtm
6 years ago (2014-12-01 22:32:18 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/772663002/1
6 years ago (2014-12-01 22:52:13 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
6 years ago (2014-12-01 22:55:27 UTC) #5
commit-bot: I haz the power
6 years ago (2014-12-01 22:56:21 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/3e2c7b0b7caaa0cc28eff1d3726b1c34f6c150fe
Cr-Commit-Position: refs/heads/master@{#306282}

Powered by Google App Engine
This is Rietveld 408576698