Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(373)

Unified Diff: tests/DeferredCanvasTest.cpp

Issue 772533004: Change clear() to respect the clip (Closed) Base URL: https://skia.googlesource.com/skia.git@master
Patch Set: rebase Created 6 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: tests/DeferredCanvasTest.cpp
diff --git a/tests/DeferredCanvasTest.cpp b/tests/DeferredCanvasTest.cpp
index da2d6b9dd34c72a10f556b368f004339284d6548..c825cba29920954ce0c1cfa076548c86094536bb 100644
--- a/tests/DeferredCanvasTest.cpp
+++ b/tests/DeferredCanvasTest.cpp
@@ -284,6 +284,7 @@ static void TestDeferredCanvasFreshFrame(skiatest::Reporter* reporter) {
canvas->restore();
REPORTER_ASSERT(reporter, !canvas->isFreshFrame());
+#if 0
mtklein 2014/12/02 15:27:37 Can you swap this to #ifdef SK_CLEAR_IGNORES_CLIP
reed1 2014/12/02 16:21:15 Shouldn't I just remove this?
// Verify that a clear with clipping triggers a fresh frame
// (clear is not affected by clipping)
canvas->save();
@@ -291,6 +292,7 @@ static void TestDeferredCanvasFreshFrame(skiatest::Reporter* reporter) {
canvas->clear(0x00000000);
canvas->restore();
REPORTER_ASSERT(reporter, canvas->isFreshFrame());
+#endif
// Verify that full frame rects with different forms of opaque paint
// trigger frames to be marked as fresh

Powered by Google App Engine
This is Rietveld 408576698