Issue 772533003: Support strict and aliased arguments in Array.prototype.slice

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 772533003: Support strict and aliased arguments in Array.prototype.slice

Created:
6 years ago by Toon Verwaest

Modified:
5 years, 10 months ago

Reviewers:
Igor Sheludko

CC:
v8-dev

Base URL:
https://chromium.googlesource.com/v8/v8.git@master

Project:
v8

Visibility:
Public.

More Reviews

Description

Support strict and aliased arguments in Array.prototype.slice BUG=

Patch Set 1 #

Patch Set 2 : #

Total comments: 2

Created: 6 years ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+67 lines, -5 lines)			Patch
	M	src/builtins.cc	View	1	3 chunks	+21 lines, -4 lines	1 comment	Download
	M	src/elements.cc	View		1 chunk	+46 lines, -1 line	1 comment	Download

Messages

Total messages: 3 (1 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

Igor Sheludko

5 years, 10 months ago (2015-01-30 14:13:29 UTC) #3

https://codereview.chromium.org/772533003/diff/20001/src/builtins.cc
File src/builtins.cc (right):

https://codereview.chromium.org/772533003/diff/20001/src/builtins.cc#newcode606
src/builtins.cc:606: if (object->map() == sloppy_arguments_map &&
Ok, elements of the |aliased_arguments_map| is a special thing, but shouldn't we
also fall back to JS here in case of |strict_arguments_map|?

https://codereview.chromium.org/772533003/diff/20001/src/elements.cc
File src/elements.cc (right):

https://codereview.chromium.org/772533003/diff/20001/src/elements.cc#newcode1715
src/elements.cc:1715: FixedArray::cast(to)->set(to_start + i, value);
I would suggest to move casts to FixedArray out of all loops although it's a nop
in release mode.

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages