Add new E2E sync multi profiles tests. This should not affect any existing

chrome/browser/sync/test/integration/p2p_sync_refresher.h

+// Copyright 2014 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#ifndef CHROME_BROWSER_SYNC_TEST_INTEGRATION_P2P_SYNC_REFRESHER_H_
+#define CHROME_BROWSER_SYNC_TEST_INTEGRATION_P2P_SYNC_REFRESHER_H_
+
+#include "base/basictypes.h"
+#include "chrome/browser/sync/profile_sync_service_observer.h"
+
+class ProfileSyncService;
+
+// This class observe ProfileSyncService events and emit refresh notifications

[Nicolas Zea, 2014/12/18 20:55:25]

grammar nit: observes and emits

[shadi, 2014/12/19 19:15:12]

Done.

+// to other test profiles for any committed changes it observes.
+//
+// It register and unregisters in its constructor and destructor.  This is
+// intended to make it easy to manage with a scoped_ptr.
+class P2PSyncRefresher : public ProfileSyncServiceObserver {

[pval...(no longer on Chromium), 2014/12/18 01:47:25]

The prefix of P2P immediately makes me think of the P2PInvalidationService and
networked peers. In reality, this thing is just an observer that replaces
notifications.

I'm trying to think of a new name that doesn't have this prefix. The first thing
that came to mind is pretty silly:
TestOnlyInProcessInvalidationServiceReplacement. Obviously this isn't a good
name. Any ideas?

[shadi, 2014/12/19 19:15:12]

I wanted to capture in the name that we are sending refresh notification to sync
clients. what about SyncClientsRefreshOnCommitObserver? :)

[pval...(no longer on Chromium), 2014/12/22 23:49:39]

ok, fair enough, I am fine with this name

+ public:
+  explicit P2PSyncRefresher(ProfileSyncService* sync_service);
+  ~P2PSyncRefresher() override;

[Nicolas Zea, 2014/12/18 20:55:25]

Hmm, I'm pretty sure this is supposed to be virtual, without the override
keyword.

[shadi, 2014/12/19 19:15:12]

Done.

+
+  // Implementation of ProfileSyncServiceObserver
+  void OnStateChanged() override;
+  void OnSyncCycleCompleted() override;
+
+ private:
+  ProfileSyncService* sync_service_;
+
+  DISALLOW_COPY_AND_ASSIGN(P2PSyncRefresher);
+};
+
+#endif  // CHROME_BROWSER_SYNC_TEST_INTEGRATION_P2P_SYNC_REFRESHER_H_