Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(321)

Unified Diff: runtime/vm/flow_graph_builder.cc

Issue 772513003: Revert r42145 to fix co19 tests (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: Created 6 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « runtime/vm/code_generator.cc ('k') | runtime/vm/intermediate_language_arm.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/vm/flow_graph_builder.cc
===================================================================
--- runtime/vm/flow_graph_builder.cc (revision 42146)
+++ runtime/vm/flow_graph_builder.cc (working copy)
@@ -38,7 +38,6 @@
DEFINE_FLAG(bool, trace_type_check_elimination, false,
"Trace type check elimination at compile time.");
-DECLARE_FLAG(bool, enable_asserts);
DECLARE_FLAG(bool, enable_type_checks);
DECLARE_FLAG(int, optimization_counter_threshold);
DECLARE_FLAG(bool, warn_on_javascript_compatibility);
@@ -885,7 +884,7 @@
void TestGraphVisitor::ReturnValue(Value* value) {
- if (FLAG_enable_type_checks || FLAG_enable_asserts) {
+ if (FLAG_enable_type_checks) {
value = Bind(new(I) AssertBooleanInstr(condition_token_pos(), value));
}
Value* constant_true = Bind(new(I) ConstantInstr(Bool::True()));
@@ -1240,7 +1239,7 @@
TestGraphVisitor for_left(owner(), node->left()->token_pos());
node->left()->Visit(&for_left);
EffectGraphVisitor empty(owner());
- if (FLAG_enable_type_checks || FLAG_enable_asserts) {
+ if (FLAG_enable_type_checks) {
ValueGraphVisitor for_right(owner());
node->right()->Visit(&for_right);
Value* right_value = for_right.value();
@@ -1305,7 +1304,7 @@
ValueGraphVisitor for_right(owner());
node->right()->Visit(&for_right);
Value* right_value = for_right.value();
- if (FLAG_enable_type_checks|| FLAG_enable_asserts) {
+ if (FLAG_enable_type_checks) {
right_value =
for_right.Bind(new(I) AssertBooleanInstr(node->right()->token_pos(),
right_value));
@@ -1764,7 +1763,7 @@
2,
owner()->ic_data_array());
if (node->kind() == Token::kNE) {
- if (FLAG_enable_type_checks || FLAG_enable_asserts) {
+ if (FLAG_enable_type_checks) {
Value* value = Bind(result);
result = new(I) AssertBooleanInstr(node->token_pos(), value);
}
@@ -1810,7 +1809,7 @@
node->operand()->Visit(&for_value);
Append(for_value);
Value* value = for_value.value();
- if (FLAG_enable_type_checks || FLAG_enable_asserts) {
+ if (FLAG_enable_type_checks) {
value =
Bind(new(I) AssertBooleanInstr(node->operand()->token_pos(), value));
}
« no previous file with comments | « runtime/vm/code_generator.cc ('k') | runtime/vm/intermediate_language_arm.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698