Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1808)

Issue 772493003: GN + Android: support standalone .dex.jar output of Android libraries. (Closed)

Created:
6 years ago by ppi
Modified:
6 years ago
Reviewers:
cjhopman, qsr
CC:
chromium-reviews, klundberg+watch_chromium.org, yfriedman+watch_chromium.org, jbudorick+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

GN + Android: support standalone .dex.jar output of Android libraries. This patch allows to set .standalone_dex_path as a variable in the android_library target. This puts all dependencies together with the library code in one dex.jar file. This is needed to produce bundles of Java code packaged as Mojo applications on Android. BUG=437290 Committed: https://crrev.com/cc9dcc51638870318f1db8a8ef7b2b6440406292 Cr-Commit-Position: refs/heads/master@{#306455}

Patch Set 1 : #

Total comments: 2

Patch Set 2 : Address Chris's comment. #

Patch Set 3 : Rebase. #

Patch Set 4 : Fix building java (non-android) libraries. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+28 lines, -4 lines) Patch
M build/android/gyp/write_build_config.py View 1 2 3 1 chunk +7 lines, -3 lines 0 comments Download
M build/config/android/internal_rules.gni View 1 2 1 chunk +12 lines, -0 lines 0 comments Download
M build/config/android/rules.gni View 1 2 3 chunks +9 lines, -1 line 0 comments Download

Messages

Total messages: 16 (5 generated)
ppi
Hi Chris, Ben; Does this look reasonable to you?
6 years ago (2014-12-01 15:07:41 UTC) #2
qsr
I can't convince me that it is better to have this option or another template, ...
6 years ago (2014-12-01 15:48:12 UTC) #4
cjhopman
I'm fine with this, lgtm. https://codereview.chromium.org/772493003/diff/20001/build/config/android/internal_rules.gni File build/config/android/internal_rules.gni (right): https://codereview.chromium.org/772493003/diff/20001/build/config/android/internal_rules.gni#newcode819 build/config/android/internal_rules.gni:819: sources = [_jar_path] add: ...
6 years ago (2014-12-01 21:47:07 UTC) #5
ppi
Thanks! https://codereview.chromium.org/772493003/diff/20001/build/config/android/internal_rules.gni File build/config/android/internal_rules.gni (right): https://codereview.chromium.org/772493003/diff/20001/build/config/android/internal_rules.gni#newcode819 build/config/android/internal_rules.gni:819: sources = [_jar_path] On 2014/12/01 21:47:07, cjhopman wrote: ...
6 years ago (2014-12-02 16:28:17 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/772493003/60001
6 years ago (2014-12-02 16:29:22 UTC) #8
commit-bot: I haz the power
Try jobs failed on following builders: android_chromium_gn_compile_rel on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/android_chromium_gn_compile_rel/builds/38826)
6 years ago (2014-12-02 16:36:24 UTC) #10
ppi
Fixed the problem hit on the trybots. Chris, could you take another look?
6 years ago (2014-12-02 18:04:42 UTC) #11
cjhopman
lgtm
6 years ago (2014-12-02 18:24:14 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/772493003/80001
6 years ago (2014-12-02 19:11:28 UTC) #14
commit-bot: I haz the power
Committed patchset #4 (id:80001)
6 years ago (2014-12-02 21:17:41 UTC) #15
commit-bot: I haz the power
6 years ago (2014-12-02 21:19:11 UTC) #16
Message was sent while issue was closed.
Patchset 4 (id:??) landed as
https://crrev.com/cc9dcc51638870318f1db8a8ef7b2b6440406292
Cr-Commit-Position: refs/heads/master@{#306455}

Powered by Google App Engine
This is Rietveld 408576698