Don't Throw Error when setting unittest config twice

Instead of Throwing an error when setting the unittest config if it has already been set we'll just display a warning.

[Nicolas Garnier, 2014-12-02 11:51:39]

Hey Kevin,

This is one of the change we discussed for the unittest library (allow
overriding of the test config).

Let me know if you'd like something else for the wording of the Warning.

Cheers!

[kevmoo, 2014-12-08 18:30:57]

On 2014/12/02 11:51:39, Nicolas Garnier wrote:
> Hey Kevin,
> 
> This is one of the change we discussed for the unittest library (allow
> overriding of the test config).
> 
> Let me know if you'd like something else for the wording of the Warning.
> 
> Cheers!

Please bump the version to 0.11.2 (behavior change) and update the changelog

[Nicolas Garnier, 2014-12-08 19:13:27]

On 2014/12/08 18:30:57, kevmoo wrote:
> On 2014/12/02 11:51:39, Nicolas Garnier wrote:
> > Hey Kevin,
> > 
> > This is one of the change we discussed for the unittest library (allow
> > overriding of the test config).
> > 
> > Let me know if you'd like something else for the wording of the Warning.
> > 
> > Cheers!
> 
> Please bump the version to 0.11.2 (behavior change) and update the changelog

Done!

[kevmoo, 2014-12-08 21:04:48]

LGTM with comments

https://codereview.chromium.org/772463003/diff/20001/pkg/unittest/CHANGELOG.md
File pkg/unittest/CHANGELOG.md (right):

https://codereview.chromium.org/772463003/diff/20001/pkg/unittest/CHANGELOG.m...
pkg/unittest/CHANGELOG.md:3: * Prints a warning instead of an throwing an
Exception when setting a test
Instead: Prints a warning instead of throwing an error when setting the test
configuration after it has already been set. The first configuration is always
used.

https://codereview.chromium.org/772463003/diff/20001/pkg/unittest/lib/unittes...
File pkg/unittest/lib/unittest.dart (right):

https://codereview.chromium.org/772463003/diff/20001/pkg/unittest/lib/unittes...
pkg/unittest/lib/unittest.dart:198: + 'unittestConfiguration ignored.');
Remove '+' adjacent string literals automatically concat.

https://codereview.chromium.org/772463003/diff/20001/pkg/unittest/lib/unittes...
pkg/unittest/lib/unittest.dart:199: return;
Use an else block instead of the in-block return

[Nicolas Garnier, 2014-12-08 21:18:15]

Done

https://codereview.chromium.org/772463003/diff/20001/pkg/unittest/CHANGELOG.md
File pkg/unittest/CHANGELOG.md (right):

https://codereview.chromium.org/772463003/diff/20001/pkg/unittest/CHANGELOG.m...
pkg/unittest/CHANGELOG.md:3: * Prints a warning instead of an throwing an
Exception when setting a test
On 2014/12/08 21:04:44, kevmoo wrote:
> Instead: Prints a warning instead of throwing an error when setting the test
> configuration after it has already been set. The first configuration is always
> used.

Done. Should have re-read myself :D

https://codereview.chromium.org/772463003/diff/20001/pkg/unittest/lib/unittes...
File pkg/unittest/lib/unittest.dart (right):

https://codereview.chromium.org/772463003/diff/20001/pkg/unittest/lib/unittes...
pkg/unittest/lib/unittest.dart:198: + 'unittestConfiguration ignored.');
On 2014/12/08 21:04:46, kevmoo wrote:
> Remove '+' adjacent string literals automatically concat.

Done.

https://codereview.chromium.org/772463003/diff/20001/pkg/unittest/lib/unittes...
pkg/unittest/lib/unittest.dart:199: return;
On 2014/12/08 21:04:45, kevmoo wrote:
> Use an else block instead of the in-block return

Done.

[Nicolas Garnier, 2014-12-08 21:18:19]

The CQ bit was checked by nivco@google.com

[Nicolas Garnier, 2014-12-08 21:18:42]

The CQ bit was unchecked by nivco@google.com

[Nicolas Garnier, 2014-12-08 21:18:43]

The CQ bit was checked by nivco@google.com

[commit-bot: I haz the power, 2014-12-08 21:21:22]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-12-08 21:21:23]

Commit queue rejected this change because it did not recognize the base URL.
Please commit your change manually.

[Nicolas Garnier, 2014-12-08 21:58:07]

Committed as: https://code.google.com/p/dart/source/detail?r=42187