Allow the content client to override browser Mojo services.

Allow the content client to override browser Mojo services.

This allows the content embedder to inject its own implementations of
Mojo services available in the browser.

BUG=421796
BUG=416426
Committed: https://crrev.com/1ca6772bd01b475be2a85a8e895612a587f6844f
Cr-Commit-Position: refs/heads/master@{#306808}

[ppi, 2014-12-01 12:51:43]

ppi@chromium.org changed reviewers:
+ qsr@chromium.org, sl.ostapenko@samsung.com, timvolodine@chromium.org

[ppi, 2014-12-01 12:53:36]

Hi Viatcheslaw,

this hook would allow you guys to override the new vibration service being
landed in https://codereview.chromium.org/583663003/ .

Could you confirm that this is indeed needed, ie. you would be using this hook?

[ostap, 2014-12-01 15:09:48]

On 2014/12/01 12:53:36, ppi wrote:
> Hi Viatcheslaw,
> 
> this hook would allow you guys to override the new vibration service being
> landed in https://codereview.chromium.org/583663003/ .
> 
> Could you confirm that this is indeed needed, ie. you would be using this
hook?

Yes, this will work.
Thanks a lot!

[ppi, 2014-12-01 15:21:05]

ppi@chromium.org changed reviewers:
+ jam@chromium.org
- qsr@chromium.org, timvolodine@chromium.org

[ppi, 2014-12-01 15:24:05]

Thanks!

Jam, this was split from https://codereview.chromium.org/734123002/ . As per
Viatcheslaw's mail above, the API will be used by Samsung. Please let us know or
see the referenced bugs if more context is needed.

[qsr, 2014-12-01 16:30:29]

qsr@chromium.org changed reviewers:
+ qsr@chromium.org

[qsr, 2014-12-01 16:30:30]

lgtm

[jam, 2014-12-02 20:52:51]

On 2014/12/01 15:24:05, ppi wrote:
> Thanks!
> 
> Jam, this was split from https://codereview.chromium.org/734123002/ . As per
> Viatcheslaw's mail above, the API will be used by Samsung. Please let us know
or
> see the referenced bugs if more context is needed.

I don't see mention of Samsung in the link above?

[ppi, 2014-12-02 21:16:14]

Hi Jam,

Sorry I didn't mean the link, but the previous comment (the one above mine) on
*this* cl. It's from Viatcheslaw @ Samsung.

[jam, 2014-12-03 21:30:24]

lgtm with nits

https://codereview.chromium.org/772433004/diff/20001/content/public/browser/c...
File content/public/browser/content_browser_client.cc (right):

https://codereview.chromium.org/772433004/diff/20001/content/public/browser/c...
content/public/browser/content_browser_client.cc:354: }
nit: remove this, it's not needed. just inline the empty body

https://codereview.chromium.org/772433004/diff/20001/content/public/browser/c...
File content/public/browser/content_browser_client.h (right):

https://codereview.chromium.org/772433004/diff/20001/content/public/browser/c...
content/public/browser/content_browser_client.h:632: virtual void
OverridePerProcessMojoServices(ServiceRegistry* registry);
nit: move this above the ifdefs, and fix indentation. also move the previous
method as well, which was the bad example here.

https://codereview.chromium.org/772433004/diff/20001/content/public/browser/c...
content/public/browser/content_browser_client.h:632: virtual void
OverridePerProcessMojoServices(ServiceRegistry* registry);
nit: maybe add Render to this, i.e. OverrideRenderProcessMojoServices(RPH*, SR*)
to make it clear it's only for renderer processes?

[ppi, 2014-12-04 12:54:50]

Thanks!

https://codereview.chromium.org/772433004/diff/20001/content/public/browser/c...
File content/public/browser/content_browser_client.cc (right):

https://codereview.chromium.org/772433004/diff/20001/content/public/browser/c...
content/public/browser/content_browser_client.cc:354: }
On 2014/12/03 21:30:24, jam wrote:
> nit: remove this, it's not needed. just inline the empty body

Done.

https://codereview.chromium.org/772433004/diff/20001/content/public/browser/c...
File content/public/browser/content_browser_client.h (right):

https://codereview.chromium.org/772433004/diff/20001/content/public/browser/c...
content/public/browser/content_browser_client.h:632: virtual void
OverridePerProcessMojoServices(ServiceRegistry* registry);
On 2014/12/03 21:30:24, jam wrote:
> nit: move this above the ifdefs, and fix indentation. also move the previous
> method as well, which was the bad example here.

Done.

https://codereview.chromium.org/772433004/diff/20001/content/public/browser/c...
content/public/browser/content_browser_client.h:632: virtual void
OverridePerProcessMojoServices(ServiceRegistry* registry);
On 2014/12/03 21:30:24, jam wrote:
> nit: maybe add Render to this, i.e. OverrideRenderProcessMojoServices(RPH*,
SR*)
> to make it clear it's only for renderer processes?

Done.

[ppi, 2014-12-04 12:54:55]

The CQ bit was checked by ppi@chromium.org

[commit-bot: I haz the power, 2014-12-04 12:55:52]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/772433004/60001

[commit-bot: I haz the power, 2014-12-04 13:55:14]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2014-12-04 13:56:05]

Patchset 4 (id:??) landed as
https://crrev.com/1ca6772bd01b475be2a85a8e895612a587f6844f
Cr-Commit-Position: refs/heads/master@{#306808}