Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1087)

Unified Diff: chrome/browser/password_manager/password_manager_util_win.cc

Issue 772413004: Revive PasswordManager.OsPasswordStatus histogram. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: blank lines Created 6 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/password_manager/chrome_password_manager_client.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/password_manager/password_manager_util_win.cc
diff --git a/chrome/browser/password_manager/password_manager_util_win.cc b/chrome/browser/password_manager/password_manager_util_win.cc
index 4eef9b45e4e0c3dfd2ce6622831041202f3551b9..30777f58f493d7e2e5c3a48ee33b44eff5f7a6eb 100644
--- a/chrome/browser/password_manager/password_manager_util_win.cc
+++ b/chrome/browser/password_manager/password_manager_util_win.cc
@@ -129,7 +129,10 @@ OsPasswordStatus GetOsPasswordStatus() {
retVal = PASSWORD_STATUS_WIN_DOMAIN;
} else {
username_length = CREDUI_MAX_USERNAME_LENGTH;
- if (GetUserName(username, &username_length)) {
+ // CheckBlankPassword() isn't safe to call on before Windows 7.
+ // http://crbug.com/345916
+ if (base::win::GetVersion() >= base::win::VERSION_WIN7 &&
+ GetUserName(username, &username_length)) {
retVal = CheckBlankPassword(username) ? PASSWORD_STATUS_BLANK :
PASSWORD_STATUS_NONBLANK;
}
« no previous file with comments | « chrome/browser/password_manager/chrome_password_manager_client.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698