Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(191)

Issue 772383003: Fix parameter types of CompareDelaySeconds from bool to int64. (Closed)

Created:
6 years ago by brucedawson
Modified:
6 years ago
Reviewers:
jianli
CC:
chromium-reviews, zea+watch_chromium.org, Lei Zhang, Bernhard Bauer, Nicolas Zea, fgorski
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Fix parameter types of CompareDelaySeconds from bool to int64. CompareDelaySeconds takes two bool parameters when it is clearly intended to take two int64 parameters. This was found by VC++'s /analyze which said: src\components\gcm_driver\gcm_driver_desktop_unittest.cc(1067) : warning C6323: Use of arithmetic operator on Boolean type(s). This bug was introduced in: https://codereview.chromium.org/561943002 BUG=427616 Committed: https://crrev.com/edef0ee80a3cb3b3d0d429c96cd124a390b500c7 Cr-Commit-Position: refs/heads/master@{#307134}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -3 lines) Patch
M components/gcm_driver/gcm_driver_desktop_unittest.cc View 2 chunks +3 lines, -3 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
brucedawson
This bug means that CompareDelaySeconds never behaved as intended. I'm not sure what the consequences ...
6 years ago (2014-12-05 00:03:53 UTC) #2
jianli
lgtm
6 years ago (2014-12-06 00:34:24 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/772383003/1
6 years ago (2014-12-06 00:35:41 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
6 years ago (2014-12-06 01:16:36 UTC) #6
commit-bot: I haz the power
6 years ago (2014-12-06 01:17:18 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/edef0ee80a3cb3b3d0d429c96cd124a390b500c7
Cr-Commit-Position: refs/heads/master@{#307134}

Powered by Google App Engine
This is Rietveld 408576698