Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(430)

Issue 772363002: Remove code to collect rules when matching. (Closed)

Created:
6 years ago by esprehn
Modified:
6 years ago
Reviewers:
ojan, eseidel
CC:
ojan, abarth-chromium, mojo-reviews_chromium.org
Base URL:
git@github.com:domokit/mojo.git@master
Project:
mojo
Visibility:
Public.

Description

Remove code to collect rules when matching. We should come up with a better way to implement this feature for the inspector, the current implementation uses CSSOM wrappers and is n^2 over the number of rules in the page. R=ojan@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/3b41144970ba99d0331179a01a4c31395e71f3dc

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -156 lines) Patch
M sky/engine/core/css/ElementRuleCollector.h View 3 chunks +0 lines, -12 lines 0 comments Download
M sky/engine/core/css/ElementRuleCollector.cpp View 4 chunks +0 lines, -85 lines 0 comments Download
M sky/engine/core/css/SelectorChecker.h View 1 chunk +1 line, -1 line 0 comments Download
M sky/engine/core/css/resolver/StyleResolver.h View 1 chunk +0 lines, -13 lines 0 comments Download
M sky/engine/core/css/resolver/StyleResolver.cpp View 1 chunk +0 lines, -23 lines 0 comments Download
M sky/engine/core/frame/LocalDOMWindow.h View 1 chunk +0 lines, -1 line 0 comments Download
M sky/engine/core/frame/LocalDOMWindow.cpp View 1 chunk +0 lines, -15 lines 0 comments Download
M sky/engine/core/frame/UseCounter.h View 1 chunk +0 lines, -1 line 0 comments Download
M sky/engine/core/frame/Window.idl View 1 chunk +0 lines, -4 lines 0 comments Download
M sky/engine/core/html/HTMLContentElement.cpp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 4 (1 generated)
esprehn
6 years ago (2014-12-03 06:34:40 UTC) #2
ojan
lgtm
6 years ago (2014-12-03 07:02:57 UTC) #3
esprehn
6 years ago (2014-12-03 07:11:05 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
3b41144970ba99d0331179a01a4c31395e71f3dc.

Powered by Google App Engine
This is Rietveld 408576698