Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(674)

Unified Diff: components/autofill/core/browser/autofill_metrics_unittest.cc

Issue 772253003: Create an autofill Suggestion class (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: merge Created 6 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/autofill/core/browser/autofill_metrics_unittest.cc
diff --git a/components/autofill/core/browser/autofill_metrics_unittest.cc b/components/autofill/core/browser/autofill_metrics_unittest.cc
index 89c99cec7cc8f0e392c3397cf4847cbbfdb3b77a..b6e596ae3aed291beff37fbebef252d4f1c6d23e 100644
--- a/components/autofill/core/browser/autofill_metrics_unittest.cc
+++ b/components/autofill/core/browser/autofill_metrics_unittest.cc
@@ -893,13 +893,12 @@ TEST_F(AutofillMetricsTest, UserHappinessFormInteraction) {
// Simulate editing an autofilled field.
{
base::HistogramTester histogram_tester;
- PersonalDataManager::GUIDPair guid(
+ SuggestionBackendID guid(
"00000000-0000-0000-0000-000000000001", 0);
- PersonalDataManager::GUIDPair empty(std::string(), 0);
autofill_manager_->FillOrPreviewForm(
AutofillDriver::FORM_DATA_ACTION_FILL,
0, form, form.fields.front(),
- autofill_manager_->PackGUIDs(empty, guid));
+ autofill_manager_->MakeFrontendID(SuggestionBackendID(), guid));
autofill_manager_->OnTextFieldDidChange(form, form.fields.front(),
TimeTicks());
// Simulate a second keystroke; make sure we don't log the metric twice.

Powered by Google App Engine
This is Rietveld 408576698