Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(568)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: components/autofill/core/browser/autofill_client.h

Issue 772253003: Create an autofill Suggestion class (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: self review 2 Created 6 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« components/autofill/core/browser/autocomplete_history_manager.cc ('K') | « components/autofill/core/browser/autocomplete_history_manager_unittest.cc ('k') | components/autofill/core/browser/autofill_external_delegate.h » ('j') | components/autofill/core/browser/autofill_manager.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: components/autofill/core/browser/autofill_client.h
diff --git a/components/autofill/core/browser/autofill_client.h b/components/autofill/core/browser/autofill_client.h
index 8cba62ca32fb199c1716b3601bec057aee62582a..d892a110ec184294d9e17077ca945a0658b4ef3a 100644
--- a/components/autofill/core/browser/autofill_client.h
+++ b/components/autofill/core/browser/autofill_client.h
@@ -33,6 +33,7 @@ class CreditCard;
class FormStructure;
class PersonalDataManager;
struct FormData;
+struct Suggestion;
// A client interface that needs to be supplied to the Autofill component by the
// embedder.
@@ -102,10 +103,7 @@ class AutofillClient {
virtual void ShowAutofillPopup(
const gfx::RectF& element_bounds,
base::i18n::TextDirection text_direction,
- const std::vector<base::string16>& values,
- const std::vector<base::string16>& labels,
- const std::vector<base::string16>& icons,
- const std::vector<int>& identifiers,
+ const std::vector<Suggestion>& suggestions,
base::WeakPtr<AutofillPopupDelegate> delegate) = 0;
// Update the data list values shown by the Autofill popup, if visible.
« components/autofill/core/browser/autocomplete_history_manager.cc ('K') | « components/autofill/core/browser/autocomplete_history_manager_unittest.cc ('k') | components/autofill/core/browser/autofill_external_delegate.h » ('j') | components/autofill/core/browser/autofill_manager.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698