Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5025)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: chrome/browser/ui/autofill/chrome_autofill_client.cc

Issue 772253003: Create an autofill Suggestion class (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: self review 2 Created 6 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« chrome/browser/ui/autofill/autofill_dialog_controller_impl.cc ('K') | « chrome/browser/ui/autofill/chrome_autofill_client.h ('k') | chrome/browser/ui/views/autofill/autofill_popup_view_views.cc » ('j') | components/autofill/core/browser/autocomplete_history_manager.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/ui/autofill/chrome_autofill_client.cc
diff --git a/chrome/browser/ui/autofill/chrome_autofill_client.cc b/chrome/browser/ui/autofill/chrome_autofill_client.cc
index dc555e4405f43650905dd09499c7a88a46c6fbcb..614143dc7c6f58393ff2a59a6d8f07318193b58c 100644
--- a/chrome/browser/ui/autofill/chrome_autofill_client.cc
+++ b/chrome/browser/ui/autofill/chrome_autofill_client.cc
@@ -143,10 +143,7 @@ void ChromeAutofillClient::ShowRequestAutocompleteDialog(
void ChromeAutofillClient::ShowAutofillPopup(
const gfx::RectF& element_bounds,
base::i18n::TextDirection text_direction,
- const std::vector<base::string16>& values,
- const std::vector<base::string16>& labels,
- const std::vector<base::string16>& icons,
- const std::vector<int>& identifiers,
+ const std::vector<autofill::Suggestion>& suggestions,
base::WeakPtr<AutofillPopupDelegate> delegate) {
// Convert element_bounds to be in screen space.
gfx::Rect client_area = web_contents_->GetContainerBounds();
@@ -162,7 +159,7 @@ void ChromeAutofillClient::ShowAutofillPopup(
element_bounds_in_screen_space,
text_direction);
- popup_controller_->Show(values, labels, icons, identifiers);
+ popup_controller_->Show(suggestions);
}
void ChromeAutofillClient::UpdateAutofillPopupDataListValues(
« chrome/browser/ui/autofill/autofill_dialog_controller_impl.cc ('K') | « chrome/browser/ui/autofill/chrome_autofill_client.h ('k') | chrome/browser/ui/views/autofill/autofill_popup_view_views.cc » ('j') | components/autofill/core/browser/autocomplete_history_manager.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698