Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3376)

Unified Diff: chrome/browser/ui/autofill/autofill_dialog_controller_impl.h

Issue 772253003: Create an autofill Suggestion class (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: self review 2 Created 6 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/autofill/autofill_dialog_controller_impl.h
diff --git a/chrome/browser/ui/autofill/autofill_dialog_controller_impl.h b/chrome/browser/ui/autofill/autofill_dialog_controller_impl.h
index 6b50e9c97178e34aa037a0756b4767646b6c3d8b..2eea2f9115a893b36f5f510dce7e075c7b83f2aa 100644
--- a/chrome/browser/ui/autofill/autofill_dialog_controller_impl.h
+++ b/chrome/browser/ui/autofill/autofill_dialog_controller_impl.h
@@ -469,11 +469,10 @@ class AutofillDialogControllerImpl
// Suggests address completions using the downloaded i18n validation rules.
// Stores the suggestions in |i18n_validator_suggestions_|.
- void GetI18nValidatorSuggestions(DialogSection section,
- ServerFieldType type,
- std::vector<base::string16>* popup_values,
- std::vector<base::string16>* popup_labels,
- std::vector<base::string16>* popup_icons);
+ void GetI18nValidatorSuggestions(
+ DialogSection section,
+ ServerFieldType type,
+ std::vector<autofill::Suggestion>* popup_suggestions);
// Like RequestedFieldsForSection, but returns a pointer.
DetailInputs* MutableRequestedFieldsForSection(DialogSection section);
@@ -745,8 +744,10 @@ class AutofillDialogControllerImpl
base::string16 transaction_amount_;
base::string16 transaction_currency_;
- // The GUIDs for the currently showing unverified profiles popup.
- std::vector<PersonalDataManager::GUIDPair> popup_guids_;
+ // The IDs for the currently showing unverified profiles popup. This will
+ // be the first section in the list. The rest of the items will be the
+ // i18n_validator_suggestions_.
+ std::vector<autofill::SuggestionBackendID> popup_suggestion_ids_;
// The autofill suggestions based on downloaded i18n validation rules.
std::vector< ::i18n::addressinput::AddressData> i18n_validator_suggestions_;

Powered by Google App Engine
This is Rietveld 408576698