Create an autofill Suggestion class

components/password_manager/core/browser/password_autofill_manager.cc

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "components/password_manager/core/browser/password_autofill_manager.h"
 
 #include <vector>
 
 #include "base/logging.h"
 #include "base/strings/string16.h"
 #include "base/strings/string_util.h"
 #include "base/strings/utf_string_conversions.h"
 #include "components/autofill/core/browser/autofill_driver.h"
 #include "components/autofill/core/browser/popup_item_ids.h"
+#include "components/autofill/core/browser/suggestion.h"
 #include "components/autofill/core/common/autofill_constants.h"
 #include "components/autofill/core/common/autofill_data_validation.h"
 #include "components/password_manager/core/browser/password_manager_client.h"
 #include "components/password_manager/core/browser/password_manager_driver.h"
 #include "components/strings/grit/components_strings.h"
 #include "ui/base/l10n/l10n_util.h"
 
 namespace password_manager {
 
 namespace {
 
 // This function attempts to fill |suggestions| and |realms| form |fill_data|
 // based on |current_username|. Unless |show_all| is true, it only picks
 // suggestions where the username has |current_username| as a prefix.
 void GetSuggestions(const autofill::PasswordFormFillData& fill_data,
                     const base::string16& current_username,
-                    std::vector<base::string16>* suggestions,
-                    std::vector<base::string16>* realms,
+                    std::vector<autofill::Suggestion>* suggestions,
                     bool show_all) {
   if (show_all ||
       StartsWith(fill_data.username_field.value, current_username, false)) {
-    suggestions->push_back(fill_data.username_field.value);
-    realms->push_back(base::UTF8ToUTF16(fill_data.preferred_realm));
+    autofill::Suggestion suggestion(fill_data.username_field.value);
+    suggestion.label = base::UTF8ToUTF16(fill_data.preferred_realm);
+    suggestion.frontend_id = autofill::POPUP_ITEM_ID_PASSWORD_ENTRY;
+    suggestions->push_back(suggestion);
   }
 
   for (const auto& login : fill_data.additional_logins) {
     if (show_all || StartsWith(login.first, current_username, false)) {
-      suggestions->push_back(login.first);
-      realms->push_back(base::UTF8ToUTF16(login.second.realm));
+      autofill::Suggestion suggestion(login.first);
+      suggestion.label = base::UTF8ToUTF16(login.second.realm);
+      suggestion.frontend_id = autofill::POPUP_ITEM_ID_PASSWORD_ENTRY;
+      suggestions->push_back(suggestion);
     }
   }
 
   for (const auto& usernames : fill_data.other_possible_usernames) {
     for (size_t i = 0; i < usernames.second.size(); ++i) {
       if (show_all ||
           StartsWith(usernames.second[i], current_username, false)) {
-        suggestions->push_back(usernames.second[i]);
-        realms->push_back(base::UTF8ToUTF16(usernames.first.realm));
+        autofill::Suggestion suggestion(usernames.second[i]);
+        suggestion.label = base::UTF8ToUTF16(usernames.first.realm);
+        suggestion.frontend_id = autofill::POPUP_ITEM_ID_PASSWORD_ENTRY;
+        suggestions->push_back(suggestion);
       }
     }
   }
 }
 
 }  // namespace
 
 ////////////////////////////////////////////////////////////////////////////////
 // PasswordAutofillManager, public:
 
@@ skipping 43 matching lines @@
 
   login_to_password_info_[key] = fill_data;
 }
 
 void PasswordAutofillManager::OnShowPasswordSuggestions(
     int key,
     base::i18n::TextDirection text_direction,
     const base::string16& typed_username,
     int options,
     const gfx::RectF& bounds) {
-  std::vector<base::string16> suggestions;
-  std::vector<base::string16> realms;
+  std::vector<autofill::Suggestion> suggestions;
   LoginToPasswordInfoMap::const_iterator fill_data_it =
       login_to_password_info_.find(key);
   if (fill_data_it == login_to_password_info_.end()) {
     // Probably a compromised renderer.
     NOTREACHED();
     return;
   }
-  GetSuggestions(fill_data_it->second, typed_username, &suggestions, &realms,
+  GetSuggestions(fill_data_it->second, typed_username, &suggestions,
                  options & autofill::SHOW_ALL);
-  DCHECK_EQ(suggestions.size(), realms.size());
 
   form_data_key_ = key;
 
   if (suggestions.empty()) {
     autofill_client_->HideAutofillPopup();
     return;
   }
 
-  std::vector<base::string16> empty(suggestions.size());
-  std::vector<int> password_ids(suggestions.size(),
-                                autofill::POPUP_ITEM_ID_PASSWORD_ENTRY);
   if (options & autofill::IS_PASSWORD_FIELD) {
-    base::string16 password_field_suggestions_title = l10n_util::GetStringUTF16(
-        IDS_AUTOFILL_PASSWORD_FIELD_SUGGESTIONS_TITLE);
-    suggestions.insert(suggestions.begin(), password_field_suggestions_title);
-    realms.insert(realms.begin(), base::string16());
-    empty.insert(empty.begin(), base::string16());
-    password_ids.insert(password_ids.begin(), autofill::POPUP_ITEM_ID_TITLE);
+    autofill::Suggestion password_field_suggestions(l10n_util::GetStringUTF16(
+        IDS_AUTOFILL_PASSWORD_FIELD_SUGGESTIONS_TITLE));
+    password_field_suggestions.frontend_id = autofill::POPUP_ITEM_ID_TITLE;
+    suggestions.insert(suggestions.begin(), password_field_suggestions);
   }
   autofill_client_->ShowAutofillPopup(bounds,
                                       text_direction,
                                       suggestions,
-                                      realms,
-                                      empty,
-                                      password_ids,
                                       weak_ptr_factory_.GetWeakPtr());
 }
 
 void PasswordAutofillManager::Reset() {
   login_to_password_info_.clear();
 }
 
 bool PasswordAutofillManager::FillSuggestionForTest(
     int key,
     const base::string16& username) {
@@ skipping 83 matching lines @@
     autofill::PasswordFormFillData* found_password) {
   LoginToPasswordInfoMap::iterator iter = login_to_password_info_.find(key);
   if (iter == login_to_password_info_.end())
     return false;
 
   *found_password = iter->second;
   return true;
 }
 
 }  //  namespace password_manager