Create an autofill Suggestion class

components/autofill/core/browser/autofill_manager.h

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef COMPONENTS_AUTOFILL_CORE_BROWSER_AUTOFILL_MANAGER_H_
 #define COMPONENTS_AUTOFILL_CORE_BROWSER_AUTOFILL_MANAGER_H_
 
 #include <list>
 #include <map>
 #include <string>
@@ skipping 179 matching lines @@
   virtual void UploadFormData(const FormStructure& submitted_form);
 
   // Logs quality metrics for the |submitted_form| and uploads the form data
   // to the crowdsourcing server, if appropriate.
   virtual void UploadFormDataAsyncCallback(
       const FormStructure* submitted_form,
       const base::TimeTicks& load_time,
       const base::TimeTicks& interaction_time,
       const base::TimeTicks& submission_time);
 
-  // Maps GUIDs to and from IDs that are used to identify profiles and credit
-  // cards sent to and from the renderer process.
-  virtual int GUIDToID(const PersonalDataManager::GUIDPair& guid) const;
-  virtual const PersonalDataManager::GUIDPair IDToGUID(int id) const;
+  // Maps SuggestionBackendID to and from an integer identifying it. Two of
+  // these intermediate integers are packed by MakeFrontendID to make the IDs
+  // that this class generates for the UI and for IPC.
+  virtual int BackendIDToInt(const SuggestionBackendID& backend_id) const;
+  virtual SuggestionBackendID IntToBackendID(int int_id) const;
 
   // Methods for packing and unpacking credit card and profile IDs for sending
   // and receiving to and from the renderer process.
-  int PackGUIDs(const PersonalDataManager::GUIDPair& cc_guid,
-                const PersonalDataManager::GUIDPair& profile_guid) const;
-  void UnpackGUIDs(int id,
-                   PersonalDataManager::GUIDPair* cc_guid,
-                   PersonalDataManager::GUIDPair* profile_guid) const;
+  int MakeFrontendID(const SuggestionBackendID& cc_backend_id,
+                     const SuggestionBackendID& profile_backend_id) const;
+  void SplitFrontendID(int frontend_id,
+                       SuggestionBackendID* cc_backend_id,
+                       SuggestionBackendID* profile_backend_id) const;
 
   const AutofillMetrics* metric_logger() const { return metric_logger_.get(); }
   void set_metric_logger(const AutofillMetrics* metric_logger);
 
   ScopedVector<FormStructure>* form_structures() { return &form_structures_; }
 
   // Exposed for testing.
   AutofillExternalDelegate* external_delegate() {
     return external_delegate_;
   }
@@ skipping 48 matching lines @@
   // |cached_form| should be a pointer to the existing version of the form, or
   // NULL if no cached version exists.  The updated form is then written into
   // |updated_form|.  Returns false if the cache could not be updated.
   bool UpdateCachedForm(const FormData& live_form,
                         const FormStructure* cached_form,
                         FormStructure** updated_form) WARN_UNUSED_RESULT;
 
   // Returns a list of values from the stored profiles that match |type| and the
   // value of |field| and returns the labels of the matching profiles. |labels|
   // is filled with the Profile label.
-  void GetProfileSuggestions(const FormStructure& form,
-                             const FormFieldData& field,
-                             const AutofillField& autofill_field,
-                             std::vector<base::string16>* values,
-                             std::vector<base::string16>* labels,
-                             std::vector<base::string16>* icons,
-                             std::vector<int>* unique_ids) const;
+  std::vector<Suggestion> GetProfileSuggestions(
+      const FormStructure& form,
+      const FormFieldData& field,
+      const AutofillField& autofill_field) const;
 
   // Returns a list of values from the stored credit cards that match |type| and
   // the value of |field| and returns the labels of the matching credit cards.
-  void GetCreditCardSuggestions(const FormFieldData& field,
-                                const AutofillType& type,
-                                std::vector<base::string16>* values,
-                                std::vector<base::string16>* labels,
-                                std::vector<base::string16>* icons,
-                                std::vector<int>* unique_ids) const;
+  std::vector<Suggestion> GetCreditCardSuggestions(
+      const FormFieldData& field,
+      const AutofillType& type) const;
 
   // Parses the forms using heuristic matching and querying the Autofill server.
   void ParseForms(const std::vector<FormData>& forms);
 
   // Imports the form data, submitted by the user, into |personal_data_|.
   void ImportFormData(const FormStructure& submitted_form);
 
   // If |initial_interaction_timestamp_| is unset or is set to a later time than
   // |interaction_timestamp|, updates the cached timestamp.  The latter check is
   // needed because IPC messages can arrive out of order.
@@ skipping 43 matching lines @@
   bool user_did_edit_autofilled_field_;
   // When the form finished loading.
   std::map<FormData, base::TimeTicks> forms_loaded_timestamps_;
   // When the user first interacted with a potentially fillable form on this
   // page.
   base::TimeTicks initial_interaction_timestamp_;
 
   // Our copy of the form data.
   ScopedVector<FormStructure> form_structures_;
 
-  // GUID to ID mapping.  We keep two maps to convert back and forth.
-  mutable std::map<PersonalDataManager::GUIDPair, int> guid_id_map_;
-  mutable std::map<int, PersonalDataManager::GUIDPair> id_guid_map_;
+  // SuggestionBackendID to ID mapping. We keep two maps to convert back and
+  // forth. These should be used only by BackendIDToInt and IntToBackendID.
+  // Note that the integers are not frontend IDs.
+  mutable std::map<SuggestionBackendID, int> backend_to_int_map_;
+  mutable std::map<int, SuggestionBackendID> int_to_backend_map_;
 
   // Delegate to perform external processing (display, selection) on
   // our behalf.  Weak.
   AutofillExternalDelegate* external_delegate_;
 
   // Delegate used in test to get notifications on certain events.
   AutofillManagerTestDelegate* test_delegate_;
 
   base::WeakPtrFactory<AutofillManager> weak_ptr_factory_;
 
@@ skipping 26 matching lines @@
   FRIEND_TEST_ALL_PREFIXES(AutofillManagerTest,
                            AutocompleteOffRespected);
   FRIEND_TEST_ALL_PREFIXES(AutofillManagerTest,
                            AutocompleteOffRespectedWithFlag);
   DISALLOW_COPY_AND_ASSIGN(AutofillManager);
 };
 
 }  // namespace autofill
 
 #endif  // COMPONENTS_AUTOFILL_CORE_BROWSER_AUTOFILL_MANAGER_H_