Create an autofill Suggestion class

components/autofill/core/browser/autocomplete_history_manager.cc

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "components/autofill/core/browser/autocomplete_history_manager.h"
 
 #include <vector>
 
 #include "base/prefs/pref_service.h"
 #include "base/profiler/scoped_tracker.h"
@@ skipping 70 matching lines @@
       static_cast<const WDResult<std::vector<base::string16> >*>(result);
   std::vector<base::string16> suggestions = autofill_result->GetValue();
   SendSuggestions(&suggestions);
 }
 
 void AutocompleteHistoryManager::OnGetAutocompleteSuggestions(
     int query_id,
     const base::string16& name,
     const base::string16& prefix,
     const std::string& form_control_type,
-    const std::vector<base::string16>& autofill_values,
-    const std::vector<base::string16>& autofill_labels,
-    const std::vector<base::string16>& autofill_icons,
-    const std::vector<int>& autofill_unique_ids) {
+    const std::vector<Suggestion>& suggestions) {
   CancelPendingQuery();
 
   query_id_ = query_id;
-  autofill_values_ = autofill_values;
-  autofill_labels_ = autofill_labels;
-  autofill_icons_ = autofill_icons;
-  autofill_unique_ids_ = autofill_unique_ids;
+  autofill_suggestions_ = suggestions;
   if (!autofill_client_->IsAutocompleteEnabled() ||
       form_control_type == "textarea") {
     SendSuggestions(NULL);
     return;
   }
 
   if (database_.get()) {
     pending_query_handle_ = database_->GetFormValuesForElementName(
         name, prefix, kMaxAutocompleteMenuItems, this);
   }
@@ skipping 48 matching lines @@
 
 void AutocompleteHistoryManager::CancelPendingQuery() {
   if (pending_query_handle_) {
     if (database_.get())
       database_->CancelRequest(pending_query_handle_);
     pending_query_handle_ = 0;
   }
 }
 
 void AutocompleteHistoryManager::SendSuggestions(
-    const std::vector<base::string16>* suggestions) {
-  if (suggestions) {
+    const std::vector<base::string16>* new_results) {

[Evan Stade, 2014/12/10 23:11:14]

s/new_results/autocomplete_results imo

+  if (new_results) {
     // Combine Autofill and Autocomplete values into values and labels.
-    for (size_t i = 0; i < suggestions->size(); ++i) {
+    for (const auto& new_result : *new_results) {
       bool unique = true;
-      for (size_t j = 0; j < autofill_values_.size(); ++j) {
+      for (const auto& autofill_suggestion : autofill_suggestions_) {
         // Don't add duplicate values.
-        if (autofill_values_[j] == (*suggestions)[i]) {
+        if (new_result == autofill_suggestion.value) {
           unique = false;
           break;
         }
       }
 
-      if (unique) {
-        autofill_values_.push_back((*suggestions)[i]);
-        autofill_labels_.push_back(base::string16());
-        autofill_icons_.push_back(base::string16());
-        autofill_unique_ids_.push_back(0);  // 0 means no profile.
-      }
+      if (unique)
+        autofill_suggestions_.push_back(Suggestion(new_result));
     }
   }
 
-  external_delegate_->OnSuggestionsReturned(query_id_,
-                                            autofill_values_,
-                                            autofill_labels_,
-                                            autofill_icons_,
-                                            autofill_unique_ids_);
+  external_delegate_->OnSuggestionsReturned(query_id_, autofill_suggestions_);
 
   query_id_ = 0;
-  autofill_values_.clear();
-  autofill_labels_.clear();
-  autofill_icons_.clear();
-  autofill_unique_ids_.clear();
+  autofill_suggestions_.clear();
 }
 
 }  // namespace autofill