Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(25)

Issue 772203003: Fix presubmit @2x recognized as @at-keyword. (Closed)

Created:
6 years ago by Dan Beam
Modified:
6 years ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Fix presubmit @2x recognized as @at-keyword. R=tbreisacher@chromium.org BUG=436768 TEST=chrome/browser/test_presubmit.py NOTRY=true NOTREECHECKS=true Committed: https://crrev.com/e5026829272c12cb03ec3396c6ffb0f94eebce0d Cr-Commit-Position: refs/heads/master@{#306560}

Patch Set 1 : fix #

Total comments: 2

Patch Set 2 : tbreisacher@ nit #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -3 lines) Patch
M chrome/browser/test_presubmit.py View 1 chunk +8 lines, -0 lines 0 comments Download
M chrome/browser/web_dev_style/css_checker.py View 1 1 chunk +3 lines, -3 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
Dan Beam
6 years ago (2014-12-03 02:54:21 UTC) #2
Tyler Breisacher (Chromium)
lgtm https://codereview.chromium.org/772203003/diff/20001/chrome/browser/web_dev_style/css_checker.py File chrome/browser/web_dev_style/css_checker.py (left): https://codereview.chromium.org/772203003/diff/20001/chrome/browser/web_dev_style/css_checker.py#oldcode38 chrome/browser/web_dev_style/css_checker.py:38: .*?} # stuff up to the first end ...
6 years ago (2014-12-03 03:37:50 UTC) #3
Dan Beam
https://codereview.chromium.org/772203003/diff/20001/chrome/browser/web_dev_style/css_checker.py File chrome/browser/web_dev_style/css_checker.py (left): https://codereview.chromium.org/772203003/diff/20001/chrome/browser/web_dev_style/css_checker.py#oldcode38 chrome/browser/web_dev_style/css_checker.py:38: .*?} # stuff up to the first end curly ...
6 years ago (2014-12-03 05:35:45 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/772203003/40001
6 years ago (2014-12-03 05:36:22 UTC) #6
commit-bot: I haz the power
Committed patchset #2 (id:40001)
6 years ago (2014-12-03 05:36:50 UTC) #7
commit-bot: I haz the power
6 years ago (2014-12-03 05:38:18 UTC) #8
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/e5026829272c12cb03ec3396c6ffb0f94eebce0d
Cr-Commit-Position: refs/heads/master@{#306560}

Powered by Google App Engine
This is Rietveld 408576698