Don't check bucket permissions if --no-auth.

Don't check bucket permissions if --no-auth.

Checking bucket permissions takes ~400ms. We don't
need to do this if --no-auth because we know we
won't get a 403 and the 404 check will be handled
later when we try to actually download the file.

Also, remove the check for a null bucket. This
can't happen since we will throw a parser error
in the main function before we get to this code.

R=iannucci@chromium.org

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=293250

[ojan, 2014-12-02 22:40:00]

ojan@chromium.org changed reviewers:
+ hinoka@chromium.org

[ojan, 2014-12-02 22:40:01]

Ryan, are you the right reviewer for this?

[ojan, 2014-12-03 21:06:58]

ojan@chromium.org changed reviewers:
+ agable@chromium.org
- hinoka@chromium.org

[ojan, 2014-12-03 21:06:58]

Looks like ryan is OOO. agable?

[ojan, 2014-12-04 17:37:19]

Incidentally, this cuts the null gclient sync time for the mojo repository from
>4s to <2s.

[iannucci, 2014-12-04 19:35:21]

iannucci@chromium.org changed reviewers:
+ iannucci@chromium.org

[iannucci, 2014-12-04 19:35:21]

lgtm

https://codereview.chromium.org/772203002/diff/1/download_from_google_storage.py
File download_from_google_storage.py (right):

https://codereview.chromium.org/772203002/diff/1/download_from_google_storage...
download_from_google_storage.py:455: base_url = 'gs://%s' % options.bucket
hah, I guess we already have a check for `not options.bucket`.

[ojan, 2014-12-04 20:09:42]

The CQ bit was checked by ojan@chromium.org

[commit-bot: I haz the power, 2014-12-04 20:10:14]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/772203002/1

[commit-bot: I haz the power, 2014-12-04 20:12:25]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-12-04 20:12:26]

Presubmit check for 772203002-1 failed and returned exit status 1.

Running presubmit commit checks ...
Checking out rietveld...
Running save-description-on-failure.sh
Running push-basic.sh
Running upstream.sh
Running submit-from-new-dir.sh
Running abandon.sh
Running submodule-merge-test.sh
Running upload-local-tracking-branch.sh
Running hooks.sh
Running post-dcommit-hook-test.sh
Running upload-stale.sh
Running patch.sh
Running basic.sh

** Presubmit ERRORS **
Pylint (110 files) (61.98s) failed
/b/depot_tools/third_party/logilab/astroid/modutils.py:520: UserWarning: Module
six was already imported from /b/depot_tools/third_party/six/__init__.py, but
/usr/local/lib/python2.7/dist-packages is being added to sys.path
  import pkg_resources
Problem importing module .svn: No module named .svn
Problem importing module .svn: No module named .svn
************* Module fix_encoding
E:232, 0: Slice index is not an int, None, or instance with __index__
(invalid-slice-index)
************* Module gclient_scm
E:301,18: No value for argument 'print_func' in constructor call
(no-value-for-parameter)
E:1191,18: No value for argument 'print_func' in constructor call
(no-value-for-parameter)


post-dcommit-hook-test.sh failed
Command
/b/infra_internal/commit_queue/workdir/tools/depot_tools/tests/post-dcommit-hook-test.sh
returned non-zero exit status 1 in
/b/infra_internal/commit_queue/workdir/tools/depot_tools/tests
Setting up test SVN repo...
Setting up test git-svn repo...
TESTING: dcommitted code
Using 50% similarity for rename/copy detection. Override with --similarity.
Description:
dcommit
TESTING: post-cl-dcommit hook executed
FAILURE: post-cl-dcommit hook executed


Presubmit checks took 127.0s to calculate.

[ojan, 2014-12-04 22:11:10]

Committed patchset #1 (id:1) manually as 293250.

[Vadim Sh., 2014-12-04 22:37:52]

A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/784433003/ by vadimsh@chromium.org.

The reason for reverting is: Seems to break download_from_google_storage.py in
gclient runhooks:

Traceback (most recent call last):
  File "/b/depot_tools/download_from_google_storage.py", line 469, in <module>
    sys.exit(main(sys.argv))
  File "/b/depot_tools/download_from_google_storage.py", line 458, in main
    code = check_bucket_permissions(base_url, gsutil, options.no_auth)
TypeError: check_bucket_permissions() takes exactly 2 arguments (3 given).

[agable, 2014-12-04 22:38:24]

https://codereview.chromium.org/772203002/diff/1/download_from_google_storage.py
File download_from_google_storage.py (right):

https://codereview.chromium.org/772203002/diff/1/download_from_google_storage...
download_from_google_storage.py:459: code = check_bucket_permissions(base_url,
gsutil, options.no_auth)
This is causing errors: sending three arguments to a function which takes only
two.