Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(28)

Issue 772193004: Remove PaintLayerPaintingChildClippingMaskPhase. (Closed)

Created:
6 years ago by ojan
Modified:
6 years ago
Reviewers:
esprehn
CC:
esprehn, abarth-chromium, mojo-reviews_chromium.org
Base URL:
git@github.com:domokit/mojo.git@master
Project:
mojo
Visibility:
Public.

Description

Remove PaintLayerPaintingChildClippingMaskPhase. It's never set. It was added in https://chromium.googlesource.com/chromium/blink/+/7176977ba5087a97ef38b1a88d0e450e924404ca%5E%21/#F21 The test cases from that patch seem to pass. Included one in this patch. R=esprehn@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/7318146c229068ba7bd70f7af99e60fd9b45f60b

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+51 lines, -30 lines) Patch
M sky/engine/core/rendering/LayerPaintingInfo.h View 1 chunk +0 lines, -1 line 0 comments Download
M sky/engine/core/rendering/RenderLayer.cpp View 6 chunks +3 lines, -29 lines 0 comments Download
A sky/tests/clipping/canvas-rounded-corners.sky View 1 chunk +24 lines, -0 lines 1 comment Download
A sky/tests/clipping/canvas-rounded-corners-expected.txt View 1 chunk +24 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
esprehn
lgtm, but without pixel tests it's hard to tell if that test really does anything. ...
6 years ago (2014-12-03 04:09:16 UTC) #2
ojan
On 2014/12/03 at 04:09:16, esprehn wrote: > lgtm, but without pixel tests it's hard to ...
6 years ago (2014-12-03 04:11:45 UTC) #3
ojan
6 years ago (2014-12-03 04:12:28 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
7318146c229068ba7bd70f7af99e60fd9b45f60b.

Powered by Google App Engine
This is Rietveld 408576698