Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(137)

Issue 772183003: Add Needed Forward Declaration (Closed)

Created:
6 years ago by zhaoze.zhou
Modified:
6 years ago
Reviewers:
tkent, brettw, jam
CC:
chromium-reviews, mlamouri+watch-content_chromium.org, posciak+watch_chromium.org, jam, mcasas+watch_chromium.org, feature-media-reviews_chromium.org, darin-cc_chromium.org, mkwst+moarreviews-renderer_chromium.org, cc-bugs_chromium.org, wjia+watch_chromium.org, mkwst+moarreviews-shell_chromium.org, jochen+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Add Needed Forward Declaration In blink side, some forward declarations were only used in chromium side. We should move these forward declarations to the files that we really need it. Committed: https://crrev.com/bf1468c0e30e3f2719f9cc5c584b583080837df8 Cr-Commit-Position: refs/heads/master@{#306869}

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -0 lines) Patch
M cc/blink/web_external_texture_layer_impl.h View 1 chunk +1 line, -0 lines 0 comments Download
M content/renderer/media/android/webmediaplayer_android.h View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M content/renderer/media/rtc_peer_connection_handler.h View 1 chunk +1 line, -0 lines 0 comments Download
M content/renderer/npapi/webplugin_impl.h View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M content/shell/renderer/test_runner/mock_web_speech_recognizer.h View 1 chunk +1 line, -0 lines 0 comments Download
M content/shell/renderer/test_runner/test_plugin.h View 1 2 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 19 (9 generated)
zhaoze.zhou
https://codereview.chromium.org/776693002/ related chromium side patch
6 years ago (2014-12-03 23:56:01 UTC) #3
zhaoze.zhou
On 2014/12/03 23:56:01, zhaoze.zhou wrote: > https://codereview.chromium.org/776693002/ related blink side patch
6 years ago (2014-12-03 23:56:15 UTC) #4
tkent
non-owner LGTM
6 years ago (2014-12-04 00:02:25 UTC) #5
jam
lgtm
6 years ago (2014-12-04 17:40:00 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/772183003/20001
6 years ago (2014-12-04 18:11:22 UTC) #11
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_gn_dbg on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_gn_dbg/builds/23095) linux_chromium_gn_rel on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_gn_rel/builds/39867)
6 years ago (2014-12-04 18:17:38 UTC) #13
zhaoze.zhou
On 2014/12/04 18:17:38, I haz the power (commit-bot) wrote: > Try jobs failed on following ...
6 years ago (2014-12-04 18:57:52 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/772183003/60001
6 years ago (2014-12-04 18:57:56 UTC) #17
commit-bot: I haz the power
Committed patchset #3 (id:60001)
6 years ago (2014-12-04 19:34:03 UTC) #18
commit-bot: I haz the power
6 years ago (2014-12-04 19:34:57 UTC) #19
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/bf1468c0e30e3f2719f9cc5c584b583080837df8
Cr-Commit-Position: refs/heads/master@{#306869}

Powered by Google App Engine
This is Rietveld 408576698