Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(71)

Issue 772133004: Move mach_message_util.* to mach_message.* (Closed)

Created:
6 years ago by Mark Mentovai
Modified:
6 years ago
Reviewers:
Robert Sesek
CC:
crashpad-dev_chromium.org
Base URL:
https://chromium.googlesource.com/crashpad/crashpad@master
Project:
crashpad
Visibility:
Public.

Description

Move mach_message_util.* to mach_message.*. A subsequent change will add MachMessageWithDeadline(), a mach_msg() wrapper. Conceptually, it makes sense to include that function in this file family. Since this file family now contains a mach_msg() wrapper, it makes sense to rename it mach_message and lose the _util suffix. R=rsesek@chromium.org Committed: https://chromium.googlesource.com/crashpad/crashpad/+/c0d5d87785cabb1135e583dd78a41354feff4c01

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -217 lines) Patch
M util/mach/child_port_server.cc View 1 chunk +1 line, -1 line 0 comments Download
M util/mach/exc_server_variants.cc View 1 chunk +1 line, -1 line 0 comments Download
M util/mach/exc_server_variants_test.cc View 1 chunk +1 line, -1 line 0 comments Download
A + util/mach/mach_message.h View 2 chunks +3 lines, -3 lines 0 comments Download
A + util/mach/mach_message.cc View 1 chunk +1 line, -1 line 0 comments Download
A + util/mach/mach_message_test.cc View 4 chunks +4 lines, -5 lines 0 comments Download
D util/mach/mach_message_util.h View 1 chunk +0 lines, -67 lines 0 comments Download
D util/mach/mach_message_util.cc View 1 chunk +0 lines, -44 lines 0 comments Download
D util/mach/mach_message_util_test.cc View 1 chunk +0 lines, -91 lines 0 comments Download
M util/util.gyp View 2 chunks +3 lines, -3 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
Mark Mentovai
These files are moving again. Sorry. The full set of changes that this is a ...
6 years ago (2014-12-02 21:47:24 UTC) #2
Robert Sesek
LGTM
6 years ago (2014-12-02 21:55:23 UTC) #3
Mark Mentovai
6 years ago (2014-12-02 22:02:37 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
c0d5d87785cabb1135e583dd78a41354feff4c01 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698