Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(778)

Issue 772133003: Mostly merge HTMLElement into Element. (Closed)

Created:
6 years ago by esprehn
Modified:
6 years ago
Reviewers:
ojan, eseidel
CC:
ojan, abarth-chromium, mojo-reviews_chromium.org
Base URL:
git@github.com:domokit/mojo.git@master
Project:
mojo
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+120 lines, -189 lines) Patch
M sky/engine/core/dom/Element.h View 5 chunks +19 lines, -4 lines 0 comments Download
M sky/engine/core/dom/Element.cpp View 3 chunks +84 lines, -1 line 0 comments Download
M sky/engine/core/dom/Element.idl View 1 chunk +16 lines, -0 lines 0 comments Download
M sky/engine/core/html/HTMLElement.h View 2 chunks +0 lines, -32 lines 0 comments Download
M sky/engine/core/html/HTMLElement.cpp View 1 chunk +0 lines, -94 lines 0 comments Download
M sky/engine/core/html/HTMLElement.idl View 1 chunk +0 lines, -14 lines 0 comments Download
M sky/engine/core/html/HTMLImageElement.h View 1 chunk +0 lines, -1 line 0 comments Download
M sky/engine/core/html/HTMLImageElement.cpp View 1 chunk +0 lines, -8 lines 0 comments Download
M sky/engine/public/web/WebElement.h View 2 chunks +1 line, -7 lines 0 comments Download
M sky/engine/web/WebElement.cpp View 2 chunks +0 lines, -28 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
esprehn
6 years ago (2014-12-02 19:50:49 UTC) #2
eseidel
lgtm
6 years ago (2014-12-02 19:54:01 UTC) #4
ojan
lgtm
6 years ago (2014-12-02 19:54:42 UTC) #5
commit-bot: I haz the power
Commit queue rejected this change because it did not recognize the base URL. Please commit ...
6 years ago (2014-12-02 19:58:04 UTC) #7
esprehn
6 years ago (2014-12-02 20:00:25 UTC) #8
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
c388ba58b02133621b4782b3b654691a8f9aa343.

Powered by Google App Engine
This is Rietveld 408576698