Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(123)

Issue 772123003: Revert "Use thumb versions of external libraries with ARMv7." (Closed)

Created:
6 years ago by pasko
Modified:
6 years ago
CC:
chromium-reviews, klundberg+watch_chromium.org, yfriedman+watch_chromium.org, jbudorick+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Revert "Use thumb versions of external libraries with ARMv7." This reverts commit 3572927ce7c9ce6d528820f9575a93985f9309bf. Reason: 9% regression on thread_renderer_compositor_cpu_time_per_frame/http___slashdot.org_. BUG=431612 TBR=brettw Committed: https://crrev.com/e7f4fa57138c2ed44235456d8bcfbe165ad1938c Cr-Commit-Position: refs/heads/master@{#306589}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+30 lines, -66 lines) Patch
M build/android/setup.gyp View 1 chunk +6 lines, -19 lines 0 comments Download
M build/common.gypi View 4 chunks +4 lines, -18 lines 0 comments Download
M build/config/android/config.gni View 3 chunks +19 lines, -24 lines 0 comments Download
M build/config/compiler/BUILD.gn View 1 chunk +1 line, -5 lines 0 comments Download

Messages

Total messages: 11 (4 generated)
pasko
clamy: please sanity-check others: FYI
6 years ago (2014-12-03 10:43:08 UTC) #2
clamy
Thanks. LGTM.
6 years ago (2014-12-03 10:46:02 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/772123003/1
6 years ago (2014-12-03 10:47:18 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/27905)
6 years ago (2014-12-03 10:51:22 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/772123003/1
6 years ago (2014-12-03 11:45:33 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
6 years ago (2014-12-03 11:47:30 UTC) #10
commit-bot: I haz the power
6 years ago (2014-12-03 11:48:17 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/e7f4fa57138c2ed44235456d8bcfbe165ad1938c
Cr-Commit-Position: refs/heads/master@{#306589}

Powered by Google App Engine
This is Rietveld 408576698