Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(531)

Unified Diff: content/browser/android/java/gin_java_method_invocation_helper.h

Issue 772123002: [Android] Java Bridge: handle requests from Java Script on the background thread (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fixed remaining crashes, added 2 WebViews test, made it pass Created 6 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/android/java/gin_java_method_invocation_helper.h
diff --git a/content/browser/android/java/gin_java_method_invocation_helper.h b/content/browser/android/java/gin_java_method_invocation_helper.h
index 014e3113194867c127a3caf7c51434e5dee5f41e..02f81d4a70117d635000937401c61b26a4e8497e 100644
--- a/content/browser/android/java/gin_java_method_invocation_helper.h
+++ b/content/browser/android/java/gin_java_method_invocation_helper.h
@@ -20,13 +20,9 @@ namespace content {
class JavaMethod;
-// Instances of this class are created and initialized on the UI thread, do
benm (inactive) 2014/12/05 17:09:33 Can we keep a comment here about the threading ple
mnaganov (inactive) 2014/12/05 18:07:40 Done.
-// their work on the background thread, and then again examined on the UI
-// thread. They don't work on both threads simultaneously, though.
class CONTENT_EXPORT GinJavaMethodInvocationHelper
: public base::RefCountedThreadSafe<GinJavaMethodInvocationHelper> {
public:
- // DispatcherDelegate is used on the UI thread
class DispatcherDelegate {
public:
DispatcherDelegate() {}
@@ -38,7 +34,6 @@ class CONTENT_EXPORT GinJavaMethodInvocationHelper
DISALLOW_COPY_AND_ASSIGN(DispatcherDelegate);
};
- // ObjectDelegate is used in the background thread
class ObjectDelegate {
public:
ObjectDelegate() {}

Powered by Google App Engine
This is Rietveld 408576698