content/browser/android/java/gin_java_bound_object.cc - Issue 772123002: [Android] Java Bridge: handle requests from Java Script on the background thread

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/android/java/gin_java_bound_object.cc

Issue 772123002: [Android] Java Bridge: handle requests from Java Script on the background thread (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Addressed benm's comment Created 6 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« content/browser/android/java/gin_java_bound_object.h ('K') | « content/browser/android/java/gin_java_bound_object.h ('k') | content/browser/android/java/gin_java_bridge_dispatcher_host.h » ('j') | content/browser/android/java/gin_java_bridge_dispatcher_host.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/android/java/gin_java_bound_object.cc

diff --git a/content/browser/android/java/gin_java_bound_object.cc b/content/browser/android/java/gin_java_bound_object.cc

index 99c8b5d14e3104c1ffc209e4f41fb991947a450f..d8bc9540d76cfce6c5c4a5cdf3ecd5ce95fa6e42 100644

--- a/content/browser/android/java/gin_java_bound_object.cc

+++ b/content/browser/android/java/gin_java_bound_object.cc

@@ -42,8 +42,8 @@ GinJavaBoundObject* GinJavaBoundObject::CreateNamed(

GinJavaBoundObject* GinJavaBoundObject::CreateTransient(

const JavaObjectWeakGlobalRef& ref,

const base::android::JavaRef<jclass>& safe_annotation_clazz,

- RenderFrameHost* holder) {

- std::set<RenderFrameHost*> holders;

+ int32 holder) {

+ std::set<int32> holders;

holders.insert(holder);

return new GinJavaBoundObject(ref, safe_annotation_clazz, holders);

}

@@ -61,7 +61,7 @@ GinJavaBoundObject::GinJavaBoundObject(

GinJavaBoundObject::GinJavaBoundObject(

const JavaObjectWeakGlobalRef& ref,

const base::android::JavaRef<jclass>& safe_annotation_clazz,

- const std::set<RenderFrameHost*> holders)

+ const std::set<int32> holders)

: ref_(ref),

names_count_(0),

holders_(holders),