Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(38)

Unified Diff: Source/core/css/resolver/StyleResolver.cpp

Issue 772103002: Collect content:attr(...)-features in RuleFeatureSet. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Avoid findPropertyIndex when possible. Created 6 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/core/css/resolver/StyleBuilderCustom.cpp ('k') | Source/core/css/resolver/StyleResolverState.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/core/css/resolver/StyleResolver.cpp
diff --git a/Source/core/css/resolver/StyleResolver.cpp b/Source/core/css/resolver/StyleResolver.cpp
index 2125d545b93fdfa362c9a7f4408efce3cfb87e42..b14c8fd0fedf7b139d4d3c4293e4cbe0399613d0 100644
--- a/Source/core/css/resolver/StyleResolver.cpp
+++ b/Source/core/css/resolver/StyleResolver.cpp
@@ -517,12 +517,6 @@ PassRefPtr<RenderStyle> StyleResolver::styleForDocument(Document& document)
return documentStyle.release();
}
-static void addContentAttrValuesToFeatures(const Vector<AtomicString>& contentAttrValues, RuleFeatureSet& features)
-{
- for (size_t i = 0; i < contentAttrValues.size(); ++i)
- features.addContentAttr(contentAttrValues[i]);
-}
-
void StyleResolver::adjustRenderStyle(StyleResolverState& state, Element* element)
{
StyleAdjuster adjuster(document().inQuirksMode());
@@ -630,8 +624,6 @@ PassRefPtr<RenderStyle> StyleResolver::styleForElement(Element* element, RenderS
applyMatchedProperties(state, collector.matchedResult());
applyCallbackSelectors(state);
- addContentAttrValuesToFeatures(state.contentAttrValues(), m_features);
-
// Cache our original display.
state.style()->setOriginalDisplay(state.style()->display());
@@ -813,8 +805,6 @@ bool StyleResolver::pseudoStyleForElementInternal(Element& element, const Pseudo
applyMatchedProperties(state, collector.matchedResult());
applyCallbackSelectors(state);
- addContentAttrValuesToFeatures(state.contentAttrValues(), m_features);
-
// Cache our original display.
state.style()->setOriginalDisplay(state.style()->display());
@@ -888,8 +878,6 @@ PassRefPtr<RenderStyle> StyleResolver::styleForPage(int pageIndex)
applyMatchedProperties<LowPriorityProperties>(state, result, false, 0, result.matchedProperties.size() - 1, inheritedOnly);
- addContentAttrValuesToFeatures(state.contentAttrValues(), m_features);
-
loadPendingResources(state);
didAccess();
« no previous file with comments | « Source/core/css/resolver/StyleBuilderCustom.cpp ('k') | Source/core/css/resolver/StyleResolverState.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698