Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(649)

Unified Diff: Source/core/css/RuleFeature.h

Issue 772103002: Collect content:attr(...)-features in RuleFeatureSet. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Avoid findPropertyIndex when possible. Created 6 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/core/css/CSSSelector.h ('k') | Source/core/css/RuleFeature.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/core/css/RuleFeature.h
diff --git a/Source/core/css/RuleFeature.h b/Source/core/css/RuleFeature.h
index 1726a4148f60a53df7be2f37382445b48a63316f..ab80cba472e53c3ad4415b10c514a28d812bc178 100644
--- a/Source/core/css/RuleFeature.h
+++ b/Source/core/css/RuleFeature.h
@@ -92,11 +92,6 @@ public:
return m_idInvalidationSets.size() > 0;
}
- // Marks the given attribute name as "appearing in a selector". Used for
- // CSS properties such as content: ... attr(...) ...
- // FIXME: record these internally to this class instead calls from StyleResolver to here.
- void addContentAttr(const AtomicString& attributeName);
-
StyleInvalidator& styleInvalidator();
void trace(Visitor*);
@@ -132,11 +127,13 @@ private:
DescendantInvalidationSet& ensureIdInvalidationSet(const AtomicString& attributeName);
DescendantInvalidationSet& ensurePseudoInvalidationSet(CSSSelector::PseudoType);
- void updateInvalidationSets(const CSSSelector&);
+ void updateInvalidationSets(const RuleData&);
+ void updateInvalidationSetsForContentAttribute(const RuleData&);
struct InvalidationSetFeatures {
InvalidationSetFeatures()
: customPseudoElement(false)
+ , hasBeforeOrAfter(false)
, treeBoundaryCrossing(false)
, adjacent(false)
, insertionPointCrossing(false)
@@ -150,6 +147,7 @@ private:
AtomicString id;
AtomicString tagName;
bool customPseudoElement;
+ bool hasBeforeOrAfter;
bool treeBoundaryCrossing;
bool adjacent;
bool insertionPointCrossing;
« no previous file with comments | « Source/core/css/CSSSelector.h ('k') | Source/core/css/RuleFeature.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698