Source/core/css/RuleFeature.h - Issue 772103002: Collect content:attr(...)-features in RuleFeatureSet.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/css/RuleFeature.h

Issue 772103002: Collect content:attr(...)-features in RuleFeatureSet. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Added TCs. Created 6 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« LayoutTests/fast/css/invalidation/content-attr-style-addition.html ('K') | « LayoutTests/fast/css/invalidation/content-attr-style-mutation-expected.html ('k') | Source/core/css/RuleFeature.cpp » ('j') | Source/core/css/RuleFeature.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/core/css/RuleFeature.h

diff --git a/Source/core/css/RuleFeature.h b/Source/core/css/RuleFeature.h

index 1726a4148f60a53df7be2f37382445b48a63316f..9491a1d73314fff3a2ea98fb14977a0b22fc1e44 100644

--- a/Source/core/css/RuleFeature.h

+++ b/Source/core/css/RuleFeature.h

@@ -92,11 +92,6 @@ public:

return m_idInvalidationSets.size() > 0;

}

- // Marks the given attribute name as "appearing in a selector". Used for

- // CSS properties such as content: ... attr(...) ...

- // FIXME: record these internally to this class instead calls from StyleResolver to here.

- void addContentAttr(const AtomicString& attributeName);

StyleInvalidator& styleInvalidator();

void trace(Visitor*);

@@ -133,6 +128,7 @@ private:

DescendantInvalidationSet& ensurePseudoInvalidationSet(CSSSelector::PseudoType);

void updateInvalidationSets(const CSSSelector&);

+ void updateInvalidationSetsForContentAttribute(StyleRule*);

struct InvalidationSetFeatures {

InvalidationSetFeatures()