chrome/renderer/plugins/plugin_uma.cc - Issue 772043004: Replace WIDEVINE_CDM_AVAILABLE with a gyp define 'enable_widevine_cdm'.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/renderer/plugins/plugin_uma.cc

Issue 772043004: Replace WIDEVINE_CDM_AVAILABLE with a gyp define 'enable_widevine_cdm'. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Switch to enable_widevine_cdm. Created 6 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« build/config/features.gni ('K') | « chrome/renderer/pepper/pepper_uma_host.cc ('k') | chrome/renderer/plugins/plugin_uma_unittest.cc » ('j') | chrome/renderer/plugins/plugin_uma_unittest.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/renderer/plugins/plugin_uma.cc

diff --git a/chrome/renderer/plugins/plugin_uma.cc b/chrome/renderer/plugins/plugin_uma.cc

index 4040f6305332f036d4a814918e575a0ef7b66033..19201a129078705b5027d3230c8bf351bdc28213 100644

--- a/chrome/renderer/plugins/plugin_uma.cc

+++ b/chrome/renderer/plugins/plugin_uma.cc

@@ -178,7 +178,7 @@ PluginUMAReporter::PluginType PluginUMAReporter::MimeTypeToPluginType(

return SHOCKWAVE_FLASH;

}

-#if defined(ENABLE_PEPPER_CDMS)

+#if defined(ENABLE_WIDEVINE_CDM) && defined(ENABLE_PEPPER_CDMS)

ddorwin 2014/12/15 18:31:06 Minor issue. I think it was intentional that this

sandersd (OOO until July 31) 2014/12/15 21:51:22 It can't be enabled because kWidevineCdmPluginMime

if (mime_type == kWidevineCdmPluginMimeType)

return WIDEVINE_CDM;

#endif